Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impr(fmt): relation qf #4953

Merged
merged 1 commit into from
Jul 15, 2024
Merged

impr(fmt): relation qf #4953

merged 1 commit into from
Jul 15, 2024

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Jul 15, 2024 •
edited
Loading

Use the relation field name instead of the referenced model name to eliminate collisions (as field names are unique)

related https://github.com/prisma/team-orm/issues/1195

@Druue
Use the relation field name instead of the referenced model name to e…
1497a6d 
…liminate collisions (as field names are unique)
@Druue Druue added this to the 5.17.0 milestone Jul 15, 2024
@Druue Druue self-assigned this Jul 15, 2024
@Druue Druue requested a review from a team as a code owner July 15, 2024 14:03
@Druue Druue requested review from Weakky and removed request for a team July 15, 2024 14:03
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 15, 2024

CodSpeed Performance Report

Merging #4953 will not alter performance

Comparing impr/qf-relation (1497a6d) with main (9721e9b)

Summary

✅ 11 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.053MiB 2.053MiB 0.000B
Postgres (gzip) 820.248KiB 820.248KiB 0.000B
Mysql 2.022MiB 2.022MiB 0.000B
Mysql (gzip) 806.666KiB 806.665KiB 1.000B
Sqlite 1.922MiB 1.922MiB 0.000B
Sqlite (gzip) 768.553KiB 768.552KiB 1.000B

@Druue Druue merged commit 393aa35 into main Jul 15, 2024
207 checks passed
@Druue Druue deleted the impr/qf-relation branch July 15, 2024 15:29
@Druue Druue mentioned this pull request Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SevInf SevInf SevInf approved these changes

@Weakky Weakky Awaiting requested review from Weakky Weakky is a code owner automatically assigned from prisma/orm-rust

Assignees

@Druue Druue

Labels
None yet
Projects
None yet
Milestone
5.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Druue @SevInf