Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prisma-schema-wasm): add get_datamodel method #4946

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Jul 9, 2024

Add get_datamodel method to get just that part of the DMMF without building, serializing, sending across WASM boundary and then deserializing the whole DMMF.

We will also need information about the indexes (currently only unique indexes are included there) and, later, spans of the entities in the schema file.

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024

CLA assistant check
All committers have signed the CLA.

@aqrln aqrln added this to the 5.17.0 milestone Jul 9, 2024
Copy link

codspeed-hq bot commented Jul 9, 2024

CodSpeed Performance Report

Merging #4946 will not alter performance

Comparing integration/schema-wasm-datamodel (e7f1052) with main (c41dd5b)

Summary

✅ 11 untouched benchmarks

@aqrln aqrln force-pushed the integration/schema-wasm-datamodel branch from 91a8585 to 5aa1a0e Compare July 9, 2024 12:22
Copy link
Contributor

github-actions bot commented Jul 9, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.044MiB 2.044MiB 0.000B
Postgres (gzip) 814.625KiB 814.626KiB -1.000B
Mysql 2.013MiB 2.013MiB 0.000B
Mysql (gzip) 801.410KiB 801.410KiB 0.000B
Sqlite 1.915MiB 1.915MiB 0.000B
Sqlite (gzip) 763.614KiB 763.613KiB 1.000B

@aqrln aqrln marked this pull request as ready for review July 9, 2024 13:23
@aqrln aqrln requested a review from a team as a code owner July 9, 2024 13:23
@aqrln aqrln requested review from Druue and removed request for a team July 9, 2024 13:23
@aqrln aqrln changed the title feat(prisma-fmt): add get_datamodel method feat(prisma-schema-wasm): add get_datamodel method Jul 9, 2024
Copy link
Contributor

@jkomyno jkomyno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aqrln
Copy link
Member Author

aqrln commented Jul 9, 2024

@jkomyno looks unrelated

Add `get_datamodel` method to get just that part of the DMMF without
building, serializing, sending across WASM boundary and then
deserializing the whole DMMF.
@aqrln aqrln force-pushed the integration/schema-wasm-datamodel branch from 5aa1a0e to e7f1052 Compare July 9, 2024 19:40
@aqrln
Copy link
Member Author

aqrln commented Jul 9, 2024

@jkomyno everything passes on another try (except one job failing due to file name being too long on windows): https://github.com/prisma/ecosystem-tests/actions/runs/9864026111/job/27238821658

@aqrln aqrln requested a review from jkomyno July 9, 2024 21:27
@aqrln aqrln merged commit 4b84e51 into main Jul 10, 2024
212 checks passed
@aqrln aqrln deleted the integration/schema-wasm-datamodel branch July 10, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants