feat: add introspectSql command #4941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4941 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
Weakky
force-pushed
the
feat/introspect-sql
branch
from
214bb3d
to
004522f
Compare
Weakky
changed the title
Weakky
commented
Jul 29, 2024
| @@ -318,7 +318,7 @@ impl Connector for PostgresDatamodelConnector { | |||
| DoublePrecision => ScalarType::Float, | |||
| // Decimal | |||
| Decimal(_) => ScalarType::Decimal, | |||
| Money => ScalarType::Float, | |||
| Money => ScalarType::Decimal, | |||
There was a problem hiding this comment.
The mapping was incorrect. I spotted it as we're using this function for native type tests
Weakky
commented
Jul 30, 2024
| &mut self, | ||
| _input: IntrospectSqlQueryInput, | ||
| ) -> BoxFuture<'_, ConnectorResult<IntrospectSqlQueryOutput>> { | ||
| unreachable!() |
There was a problem hiding this comment.
question: does the client gate the engine from being called at all?
Weakky
commented
Jul 30, 2024
Weakky
commented
Jul 30, 2024
|
|
||
| let res = parse_sql_doc( | ||
| r#" -- @description This query returns a user by it's id | ||
| -- @param {Int} $1:userId valid user identifier |
There was a problem hiding this comment.
how about we accept typescript types instead?
There was a problem hiding this comment.
Even just supporting {Type | null} using Prisma scalar types would be a considerable improvement, imho
Weakky
commented
Jul 30, 2024
Weakky
commented
Jul 30, 2024
Weakky
commented
Jul 30, 2024
schema-engine/sql-migration-tests/tests/query_introspection/mysql.rs
Outdated
Show resolved
Hide resolved
Weakky
commented
Jul 30, 2024
schema-engine/connectors/sql-schema-connector/src/flavour/mysql/connection.rs
Show resolved
Hide resolved
jkomyno
reviewed
Jul 31, 2024
jkomyno
reviewed
Jul 31, 2024
schema-engine/connectors/sql-schema-connector/src/flavour/mysql/connection.rs
Show resolved
Hide resolved
jkomyno
reviewed
Jul 31, 2024
SevInf
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes https://github.com/prisma/team-orm/issues/1222
closes https://github.com/prisma/team-orm/issues/1248
Implements https://www.notion.so/prismaio/Typed-SQL-76c1b7999b74421eb59f921bab7e878a?pvs=4