psl: simplify attribute list validation #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since type aliases are not a thing, `AttributesValidationState.attributes` does not need to be a Vec anymore (we were accumulating attributes defined on the model and on aliases), it can be an Option. This is simpler to reason about.
CodSpeed Performance ReportMerging #4237 will degrade performances by 5.67%Comparing Summary
Benchmarks breakdown
|
Druue
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since type aliases are not a thing anymore,
AttributesValidationState.attributesdoes not need to be a Vec anymore (we were accumulating attributes defined on the model and on aliases), it can be an Option. This is simpler to reason about.