Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quaint): remove json conditional flag #4232

Merged
merged 1 commit into from
Sep 13, 2023
Merged

feat(quaint): remove json conditional flag #4232

merged 1 commit into from
Sep 13, 2023

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Sep 13, 2023

@jkomyno jkomyno added this to the 5.4.0 milestone Sep 13, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 13, 2023

CodSpeed Performance Report

Merging #4232 will not alter performance

Comparing feat/quaint-remove-json (25a7735) with main (5106138)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno marked this pull request as ready for review September 13, 2023 09:22
@jkomyno jkomyno requested a review from a team as a code owner September 13, 2023 09:22
miguelff
miguelff approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@miguelff miguelff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Weakky
Weakky approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@Weakky Weakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading this feels like someone's removing a nail from my back 💯

@miguelff miguelff merged commit b90a820 into main Sep 13, 2023
64 checks passed
@miguelff miguelff deleted the feat/quaint-remove-json branch September 13, 2023 16:02
jkomyno added a commit that referenced this pull request Sep 18, 2023
@jkomyno
Revert "feat(quaint): remove "json" conditional flag (#4232)"
ea3412e 
This reverts commit b90a820.
@jkomyno jkomyno mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelff miguelff miguelff approved these changes

@Weakky Weakky Weakky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jkomyno @miguelff @Weakky