Skip to content

Commit

Permalink
fix(ci): fix schema-engine for SQL Server 2017
Browse files Browse the repository at this point in the history
  • Loading branch information
jkomyno committed Sep 23, 2024
1 parent f7cdacd commit 5aebbbf
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-query-engine-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
required: true
ubuntu:
type: string
required: true
default: 'latest'
single_threaded:
type: boolean
default: false
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/test-query-engine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,8 @@ jobs:
database:
- name: "mssql_2022"
version: "2022"
ubuntu: "latest"
- name: "mssql_2019"
version: "2019"
ubuntu: "latest"
- name: "mssql_2017"
version: "2017"
ubuntu: "20.04"
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/test-schema-engine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ jobs:
database:
- name: mssql_2017
url: "sqlserver://localhost:1434;database=master;user=SA;password=<YourStrong@Passw0rd>;trustServerCertificate=true;socket_timeout=60;isolationLevel=READ UNCOMMITTED"
ubuntu: "20.04"
- name: mssql_2019
url: "sqlserver://localhost:1433;database=master;user=SA;password=<YourStrong@Passw0rd>;trustServerCertificate=true;socket_timeout=60;isolationLevel=READ UNCOMMITTED"
- name: mssql_2022
Expand Down Expand Up @@ -104,7 +105,7 @@ jobs:
is_vitess: true
single_threaded: true

runs-on: ubuntu-latest
runs-on: "ubuntu-${{ matrix.database.ubuntu || 'latest' }}"
steps:
- uses: actions/checkout@v4
- uses: actions-rust-lang/setup-rust-toolchain@v1
Expand Down

0 comments on commit 5aebbbf

Please sign in to comment.