Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove full rails as a runtime dependency #404

Merged
merged 16 commits into from
Apr 6, 2021
Merged

Remove full rails as a runtime dependency #404

merged 16 commits into from
Apr 6, 2021

Conversation

manuelpuyol
Copy link
Contributor

@manuelpuyol manuelpuyol commented Mar 24, 2021 •
edited
Loading

Updated the gemspec requirements to only depend on actionview and activesupport.
Also updated to octicons_helper > 13 so we don't have a full rails dependency!

cc @colebemis

@vercel
Copy link

vercel bot commented Mar 24, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/view-components/9xmdi9ztF5Z2PwDtCqJhyuf4tqtT
✅ Preview: https://view-components-git-dont-depend-on-rails-primer.vercel.app

manuelpuyol
manuelpuyol commented Mar 24, 2021
View reviewed changes
app/components/primer/octicon_component.rb
Comment on lines -8 to -10
include ClassNameHelper
include TestSelectorHelper
include OcticonsHelper
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of those are included by Primer::Component

@srt32 srt32 mentioned this pull request Mar 24, 2021
Closed
@vercel vercel bot temporarily deployed to Preview March 24, 2021 19:46 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2021 20:15 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2021 21:00 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2021 21:02 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2021 21:22 Inactive
@vercel vercel bot temporarily deployed to Preview March 24, 2021 21:30 Inactive
@manuelpuyol manuelpuyol marked this pull request as ready for review March 24, 2021 21:30
@manuelpuyol manuelpuyol requested a review from srt32 March 24, 2021 21:31
manuelpuyol
manuelpuyol commented Mar 24, 2021
View reviewed changes
Gemfile Outdated Show resolved Hide resolved
demo/Gemfile Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview March 24, 2021 21:32 Inactive
@manuelpuyol manuelpuyol changed the title Dont depend on rails Remove full rails as a runtime dependency Mar 24, 2021
@vercel vercel bot temporarily deployed to Preview April 6, 2021 18:46 Inactive
@manuelpuyol manuelpuyol mentioned this pull request Apr 6, 2021
Closed
@vercel vercel bot temporarily deployed to Preview April 6, 2021 18:49 Inactive
@manuelpuyol manuelpuyol merged commit 3a9ba7d into main Apr 6, 2021
@manuelpuyol manuelpuyol deleted the dont-depend-on-rails branch April 6, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelhawksley joelhawksley joelhawksley approved these changes

@srt32 srt32 Awaiting requested review from srt32

@colebemis colebemis Awaiting requested review from colebemis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuelpuyol @joelhawksley