Skip to content

Add missing SR announcement in Summary As Button story #3867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
llastflowers merged 5 commits into from
Jan 22, 2026
Merged

Add missing SR announcement in Summary As Button story #3867

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b05859b
add missing sr announcement
llastflowers Jan 21, 2026
a32e31c
Fix typo in SR announcement for Summary As Button story
llastflowers Jan 21, 2026
fc67820
Update previews/primer/beta/button_preview/summary_as_button.html.erb
llastflowers Jan 21, 2026
6a46729
Update previews/primer/beta/button_preview/summary_as_button.html.erb
llastflowers Jan 21, 2026
1616537
lint fixes
llastflowers Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion previews/primer/beta/button_preview/summary_as_button.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
<details>
<span
id="button-summary-live"
class="sr-only"
role="alert"
Comment thread
llastflowers marked this conversation as resolved.
Outdated
aria-atomic="true"
></span>

<details
onToggle="document.getElementById('button-summary-live').textContent = this.open ? 'A wrapping `details` tag is required when using the button with the `:summary` tag' : ''"
Comment thread
llastflowers marked this conversation as resolved.
Outdated
>
Comment thread
llastflowers marked this conversation as resolved.
Outdated
<%= render(Primer::Beta::Button.new(
scheme: scheme,
size: size,
Expand All @@ -9,5 +18,6 @@
)) do %>
Button
<% end %>

<p>A wrapping `details` tag is required when using the button with the `:summary` tag</p>
</details>
Loading