Skip to content

Update for Ruby 4 #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonrohan merged 6 commits into from
Jan 12, 2026
Merged

Update for Ruby 4 #3848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef5d1c0
add allocations for ruby 4.0
joelhawksley Jan 12, 2026
e4d92d1
npm install
joelhawksley Jan 12, 2026
dcc991e
set longer timeout for a11y job
joelhawksley Jan 12, 2026
357a1e1
add longer timeout for css coverage test
joelhawksley Jan 12, 2026
45193fe
Create healthy-days-hide.md
joelhawksley Jan 12, 2026
edf4b0f
Merge branch 'main' into ruby-4
joelhawksley Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-days-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/view-components": patch
---

Add support for Ruby 4 in test suite.
3 changes: 3 additions & 0 deletions .github/workflows/test-accessibility.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ concurrency:
group: test-accessibility-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

env:
FERRUM_PROCESS_TIMEOUT: 30

jobs:
accessibility:
name: Accessibility
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test-selectors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ concurrency:
group: test-selectors-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

env:
FERRUM_PROCESS_TIMEOUT: 30

jobs:
selectors:
name: CSS coverage
Expand Down
58 changes: 50 additions & 8 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/performance/bench_classify.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def setup
end

def bench_allocations
assert_allocations "3.4" => 7, "3.3" => 7, "3.2" => 6, "3.1" => 6, "3.0" => 6, "2.7" => 4 do
assert_allocations "4.0" => 7, "3.4" => 7, "3.3" => 7, "3.2" => 6, "3.1" => 6, "3.0" => 6, "2.7" => 4 do
Primer::Classify.call(**@values)
end
end
Expand Down
Loading
Loading