Prevent hidden inputs from taking up space on the page #3202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes an issue where hidden inputs created with the forms framework would take up vertical/horizontal space on the page. Depending on the form, this can lead to weird visual spacing issues. This has been a problem for a while, but was recently exacerbated by #3087 (merged as #3159).
Screenshots
This is difficult to show in a screenshot because the input itself is not visible.
Integration
No changes necessary in production.
List the issues that this change affects.
Fixes #3194
Risk Assessment
What approach did you choose and why?
All inputs are wrapped in the
Group
component, so I added some logic that addsdisplay: none
to groups that contain only hidden inputs.Accessibility
Merge checklist
- [ ] Added/updated documentationTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.