Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-spiders-push.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

update SelectPanel Multi Select Modal story
Original file line number Diff line number Diff line change
Expand Up @@ -783,13 +783,13 @@

export const MultiSelectModal = () => {
const [initialSelection, setInitialSelection] = React.useState<ItemInput[]>(items.slice(1, 3))

const [selected, setSelected] = React.useState<ItemInput[]>(initialSelection)
const [savedSelection, setSavedSelection] = React.useState<ItemInput[]>(initialSelection)
const [filter, setFilter] = React.useState('')
const [open, setOpen] = useState(false)

React.useEffect(() => {
Comment thread
llastflowers marked this conversation as resolved.
if (!open) setInitialSelection(selected) // Save selection as initialSelection for next time
if (!open) setInitialSelection(selected)
}, [open, selected])

const filteredItems = items.filter(item => item.text.toLowerCase().startsWith(filter.toLowerCase()))
Expand All @@ -800,13 +800,18 @@
title="Select labels"
placeholder="Select labels"
subtitle="Use labels to organize issues and pull requests"
renderAnchor={({children, ...anchorProps}) => (

Check failure on line 803 in packages/react/src/SelectPanel/SelectPanel.features.stories.tsx

View workflow job for this annotation

GitHub Actions / lint

'children' is defined but never used. Allowed unused args must match /^_/u
<Button trailingAction={TriangleDownIcon} {...anchorProps} aria-haspopup="dialog">
{children}
{savedSelection.map(item => item.text).join(', ') || 'Select labels'}
</Button>
)}
open={open}
onOpenChange={setOpen}
onOpenChange={(nextOpen, gesture) => {
setOpen(nextOpen)
if (!nextOpen && gesture === 'selection') {
setSavedSelection(selected)
}
}}
items={filteredItems}
selected={selected}
onSelectedChange={setSelected}
Expand Down
Loading