-
Notifications
You must be signed in to change notification settings - Fork 670
perf(hooks): Add opt-in throttling to useResizeObserver and useOverflow #7335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1c12057
perf(hooks): Add first-immediate throttling to useResizeObserver and …
mattcosta7 0401efc
Merge branch 'main' into perf/use-resize-observer
mattcosta7 f3b33a7
Merge branch 'main' into perf/use-resize-observer
mattcosta7 9c91b8d
update throttling behavior
mattcosta7 eb691f9
Merge branch 'main' into perf/use-resize-observer
mattcosta7 45f06d2
avoid mcoking in tests
mattcosta7 efde70a
Merge branch 'main' into perf/use-resize-observer
siddharthkp 64a0de0
Merge branch 'main' into perf/use-resize-observer
mattcosta7 b999a75
Merge branch 'main' into perf/use-resize-observer
mattcosta7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| '@primer/react': patch | ||
| --- | ||
|
|
||
| perf(hooks): Add first-immediate throttling to useResizeObserver and useOverflow | ||
|
|
||
| - useResizeObserver now fires callback immediately on first observation, then throttles with rAF | ||
| - useOverflow now uses the same pattern to avoid initial flash of incorrect overflow state | ||
| - Added isFirstCallback ref pattern to skip throttling on initial mount |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is a current bug, since things can never go to
not overflowstates