Skip to content

fix(Popover): use stable empty array reference to prevent unnecessary re-renders #7064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francinelucca merged 2 commits into from
Oct 23, 2025
Merged

fix(Popover): use stable empty array reference to prevent unnecessary re-renders #7064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bc62ed
Initial plan
Copilot Oct 23, 2025
2f2f7db
fix: use stable empty array reference for ignoreClickRefs to avoid un…
Copilot Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/Popover/Popover.features.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {Meta, StoryFn} from '@storybook/react-vite'
import type {Meta} from '@storybook/react-vite'
import Heading from '../Heading'
import Popover from './Popover'
import Text from '../Text'
Expand Down
5 changes: 4 additions & 1 deletion packages/react/src/Popover/Popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ import type {HTMLProps} from 'react'
import React, {useRef} from 'react'
import {useOnOutsideClick} from '../hooks'

// Stable empty array reference to avoid unnecessary re-renders
const EMPTY_IGNORE_CLICK_REFS: React.RefObject<HTMLElement>[] = []

type CaretPosition =
| 'top'
| 'bottom'
Expand Down Expand Up @@ -75,7 +78,7 @@ const PopoverContent: React.FC<React.PropsWithChildren<PopoverContentProps>> = (
useOnOutsideClick({
onClickOutside: onClickOutside ?? (() => null),
containerRef: divRef,
ignoreClickRefs: ignoreClickRefs ?? [],
ignoreClickRefs: ignoreClickRefs ?? EMPTY_IGNORE_CLICK_REFS,
})

return (
Expand Down