Skip to content

Remove unwanted box-shadow on inactive buttons #6981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mperrotti merged 11 commits into from
Oct 16, 2025
Merged

Remove unwanted box-shadow on inactive buttons #6981

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a77bb50
removes box-shadow for inactive buttons
mperrotti Oct 10, 2025
fb27808
updates LinkButton stories to demo variant='link'
mperrotti Oct 10, 2025
6b36d9c
test(vrt): update snapshots
mperrotti Oct 10, 2025
37fac86
Merge branch 'mp/button-papercuts-oct2025' of github.com:primer/react…
mperrotti Oct 14, 2025
93ce2db
Merge branch 'main' of github.com:primer/react into mp/button-papercu…
mperrotti Oct 14, 2025
5e310a8
Merge branch 'main' into mp/button-papercuts-oct2025
mperrotti Oct 14, 2025
d219a1e
Merge branch 'main' into mp/button-papercuts-oct2025
mperrotti Oct 15, 2025
202254d
Merge branch 'main' into mp/button-papercuts-oct2025
mperrotti Oct 16, 2025
b012740
adds changeset
mperrotti Oct 16, 2025
5d7e95e
Merge branch 'main' into mp/button-papercuts-oct2025
francinelucca Oct 16, 2025
2700ee2
test(vrt): update snapshots
mperrotti Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-wolves-judge.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Removes unwanted box-shadow on buttons with 'inactive' prop passed.
4 changes: 4 additions & 0 deletions e2e/components/LinkButton.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ const stories = [
title: 'Invisible',
id: 'components-linkbutton-features--invisible',
},
{
title: 'Link',
id: 'components-linkbutton-features--link',
},
{
title: 'Large',
id: 'components-linkbutton-features--large',
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/Button/ButtonBase.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,7 @@
background-color: var(--button-inactive-bgColor);
/* stylelint-disable-next-line primer/colors */
border-color: var(--button-inactive-bgColor);
box-shadow: none;

& .Visual,
& .CounterLabel {
Expand Down
6 changes: 6 additions & 0 deletions packages/react/src/Button/LinkButton.features.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ export const Invisible = () => (
</LinkButton>
)

export const Link = () => (
<LinkButton href="#" variant="link">
Button that looks like a link
</LinkButton>
)

export const LeadingVisual = () => (
<LinkButton href="#" leadingVisual={HeartIcon}>
Leading visual
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Button/LinkButton.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Playground.argTypes = {
control: {
type: 'radio',
},
options: ['default', 'primary', 'danger', 'invisible', 'outline'],
options: ['default', 'primary', 'danger', 'invisible', 'outline', 'link'],

@francinelucca francinelucca Oct 16, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing this? 👀

@mperrotti mperrotti Oct 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean adding?

},
alignContent: {
control: {
Expand Down
Loading