Skip to content

[SelectPanel] Announce loading prop changes #6404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hectahertz merged 2 commits into from
Jul 29, 2025
Merged

[SelectPanel] Announce loading prop changes #6404

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7977188
Announce loading prop changes
hectahertz Jul 28, 2025
56779a3
Add changeset
hectahertz Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/react/src/SelectPanel/SelectPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,23 @@ function Panel({
}
}, [inputRef, open])

// Manage loading announcements when loadingManagedExternally
useEffect(() => {
if (loadingManagedExternally) {
if (isLoading) {
// Delay the announcement a bit, just in case the loading is quick
loadingDelayTimeoutId.current = safeSetTimeout(() => {
announceLoading()
}, LONG_DELAY_MS)
} else {
// If loading is done, we can clear the loading announcement
if (loadingDelayTimeoutId.current) {
safeClearTimeout(loadingDelayTimeoutId.current)
}
}
}
}, [isLoading, loadingManagedExternally, safeSetTimeout, safeClearTimeout])

// Populate panel with items on first open
useEffect(() => {
if (loadingManagedExternally) return
Expand Down
Loading