Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-cooks-collect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Align `font` with PVC for Tooltip
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions e2e/components/IconButton.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ const stories = [
{
title: 'Keybinding Hint on Description',
id: 'components-iconbutton-features--keybinding-hint-on-description',
disableAnimations: true,
async setup(page: Page) {
await page.keyboard.press('Tab') // focus on icon button
await page.getByText('You have unread notifications').waitFor({
Expand Down
9 changes: 3 additions & 6 deletions packages/react/src/TooltipV2/Tooltip.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,13 @@
width: max-content;
max-width: 250px;
/* stylelint-disable-next-line primer/spacing */
padding: 0.5em 0.75em;
padding: var(--overlay-paddingBlock-condensed) var(--overlay-padding-condensed);
margin: auto;

/* for scrollbar */
overflow: visible;
clip: auto;
/* stylelint-disable-next-line primer/typography */
font: normal normal 11px/1.5 var(--fontStack-system);
font: var(--text-body-shorthand-small);
color: var(--tooltip-fgColor);
text-align: center;
word-wrap: break-word;
Expand All @@ -35,6 +34,7 @@
border-radius: var(--borderRadius-medium);
-webkit-font-smoothing: subpixel-antialiased;
inset: auto;
Copy link

Copilot AI Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text-wrap: balance property has limited browser support and may not work in older browsers. Consider adding a fallback or checking if this aligns with the project's browser support requirements.

Suggested change
inset: auto;
inset: auto;
word-wrap: break-word; /* Fallback for older browsers */
overflow-wrap: break-word; /* Ensures compatibility */

Copilot uses AI. Check for mistakes.
text-wrap: balance;
}

/* class name in chrome is :popover-open */
Expand Down Expand Up @@ -123,8 +123,5 @@
}

.KeybindingHintContainer.HasTextBefore {
/* Offset negative on the right right to make right spacing look like top and bottom spacing, only for keybinding hints and only when there is text */
/* stylelint-disable-next-line primer/spacing */
margin-right: -0.125em;
margin-left: var(--base-size-6);
}
Loading