Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ActionList sub components) Convert to CSS Modules #5398

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
cbcb00e
copy
langermank Dec 6, 2024
b4073f2
copy all
langermank Dec 7, 2024
a59907b
fix padding
langermank Dec 9, 2024
c43d0c6
Merge branch 'main' into al-trailingaction-css
langermank Dec 9, 2024
6dfcba7
Merge branch 'main' into al-trailingaction-css
langermank Dec 10, 2024
e1e1e85
add heading
langermank Dec 10, 2024
d5e8275
fix selectpanel story
langermank Dec 10, 2024
025bf4b
Merge branch 'main' into al-trailingaction-css
langermank Dec 10, 2024
e6034c2
vrt
langermank Dec 10, 2024
9fe5820
alignment
langermank Dec 10, 2024
ecf8fe6
Merge branch 'main' into al-trailingaction-css
langermank Dec 10, 2024
1f4d117
moar fixes
langermank Dec 10, 2024
270931a
dev stories
langermank Dec 10, 2024
abc7ae5
Merge branch 'main' into al-trailingaction-css
langermank Dec 11, 2024
5c76a85
tests
langermank Dec 11, 2024
3c980dd
moving tests around
langermank Dec 11, 2024
27514c9
tests
langermank Dec 11, 2024
04f1f6b
tests
langermank Dec 11, 2024
4052c0a
Apply suggestions from code review
langermank Dec 11, 2024
59cd1d2
prettier
langermank Dec 11, 2024
cd152f6
lint
langermank Dec 11, 2024
41bf57e
test(vrt): update snapshots
langermank Dec 11, 2024
5cbff43
fix nesting issue
langermank Dec 11, 2024
f29109a
reset
langermank Dec 11, 2024
27e886d
test(vrt): update snapshots
langermank Dec 11, 2024
3dbafc9
vrt
langermank Dec 11, 2024
f0ec417
cleanup
langermank Dec 11, 2024
ece68c5
Merge branch 'main' into al-trailingaction-css
langermank Dec 11, 2024
6549d5d
reset
langermank Dec 11, 2024
7240b84
test(vrt): update snapshots
langermank Dec 11, 2024
8968919
very sad and annoying
langermank Dec 12, 2024
a3850cf
snaps
langermank Dec 12, 2024
d482cb1
Create dirty-nails-applaud.md
langermank Dec 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dirty-nails-applaud.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

Convert ActionList + sub components to CSS Modules
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
@define-mixin activeIndicatorLine {
position: absolute;
top: calc(50% - var(--base-size-12));
left: calc(-1 * var(--base-size-8));
width: var(--base-size-4);
height: var(--base-size-24);
content: '';
background: var(--bgColor-accent-emphasis);
border-radius: var(--borderRadius-medium);
}
21 changes: 21 additions & 0 deletions packages/react/src/ActionList/ActionList.dev.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {Group} from './Group'
import {Divider} from './Divider'
import {Description} from './Description'
import Avatar from '../Avatar'
import {FileDirectoryIcon} from '@primer/octicons-react'

export default {
title: 'Components/ActionList/Dev',
Expand Down Expand Up @@ -144,3 +145,23 @@ export const HeadingCustomClassname = () => (
</ActionList.Group>
</ActionList>
)

export const DescriptionCustomClassname = () => (
<ActionList>
<ActionList.Item>
Label
<ActionList.Description className="testCustomClassnameColor">This is a description</ActionList.Description>
</ActionList.Item>
</ActionList>
)

export const VisualCustomClassname = () => (
<ActionList>
<ActionList.Item>
Label
<ActionList.LeadingVisual className="testCustomClassnameColor">
<FileDirectoryIcon />
</ActionList.LeadingVisual>
</ActionList.Item>
</ActionList>
)
Loading
Loading