Skip to content

Add className prop support to <Textarea> #5130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshblack merged 5 commits into from
Oct 16, 2024
Merged

Add className prop support to <Textarea> #5130

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb59d85
Add className prop support
randall-krauskopf Oct 15, 2024
25dccb5
Fix Textarea component className prop formatting
randall-krauskopf Oct 15, 2024
9d7a4f8
patch -> minor
randall-krauskopf Oct 15, 2024
f62798b
Update prop description
randall-krauskopf Oct 15, 2024
dd7e5f6
Remove defaultValue from className in Textarea docs
randall-krauskopf Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wicked-ties-walk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
Comment thread
randall-krauskopf marked this conversation as resolved.
Outdated
---

Add `className` prop support to `Textarea` component
8 changes: 7 additions & 1 deletion packages/react/src/Textarea/Textarea.docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,13 @@
{
"name": "sx",
"type": "SystemStyleObject"
},
{
"name": "className",
"type": "string | undefined",
"defaultValue": "",
"description": "CSS string"
Comment thread
randall-krauskopf marked this conversation as resolved.
Outdated
}
],
"subcomponents": []
}
}
6 changes: 6 additions & 0 deletions packages/react/src/Textarea/Textarea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@ export type TextareaProps = {
* apply a high contrast color to background
*/
contrast?: boolean
/**
* The className to apply to the wrapper element
*/
className?: string
} & TextareaHTMLAttributes<HTMLTextAreaElement> &
SxProp

Expand Down Expand Up @@ -79,6 +83,7 @@ const Textarea = React.forwardRef<HTMLTextAreaElement, TextareaProps>(
resize = DEFAULT_TEXTAREA_RESIZE,
block,
contrast,
className,
...rest
}: TextareaProps,
ref,
Expand All @@ -90,6 +95,7 @@ const Textarea = React.forwardRef<HTMLTextAreaElement, TextareaProps>(
disabled={disabled}
block={block}
contrast={contrast}
className={className}
>
<StyledTextarea
value={value}
Expand Down