Skip to content

WIP: Select panel announcements #4927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
siddharthkp wants to merge 101 commits into from
Closed

WIP: Select panel announcements #4927

siddharthkp wants to merge 101 commits into from

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Sep 6, 2024 •
edited
Loading

broccolinisoup and others added 30 commits July 30, 2024 14:51
@broccolinisoup
super wip
9cee0a4
@broccolinisoup
just use the actionlist component and revert the type updates
c7aa5de
@broccolinisoup
Update packages/react/src/FilteredActionList/FilteredActionList.tsx
40a0c45
@broccolinisoup
Some more progress
344f6ce
@broccolinisoup
revert the type changes and cast it :/
fa5f5a6
@broccolinisoup
clean
3cd9ecc
@broccolinisoup
wip
0003e59
@broccolinisoup
wip wip
713b5ad
@broccolinisoup
add stories
6fc7f2b
@broccolinisoup
fix linting
a246981
@broccolinisoup
add tests for groups
e209f47
@broccolinisoup
Merge branch 'main' into select-panel-action-list
26cddc1
@broccolinisoup
Merge branch 'select-panel-story-and-tests' into select-panel-action-…
b1199fb 
…list
@broccolinisoup
Map groups
b669cff
@broccolinisoup
Merge branch 'main' into select-panel-story-and-tests
1012662
@broccolinisoup
Update story names for e2e tests
67dc5c9
@broccolinisoup
oops remove unintended file
c66feb5
@broccolinisoup
update story name
4fbb3c5
@broccolinisoup
same - update story name
2d5e2b2
@broccolinisoup
disable animations
cee7737
@broccolinisoup @github-actions
test(vrt): update snapshots
9c972c3
@broccolinisoup
Merge branch 'select-panel-story-and-tests' into select-panel-action-…
17e4ca8 
…list
@broccolinisoup
Update tests since new action list has different semantics for group …
26b6fe6 
…headings
@broccolinisoup
Merge branch 'main' into select-panel-action-list
42c50c0
@broccolinisoup
logging
0d0004f
@broccolinisoup
pass the rest
3ba9bc7
@broccolinisoup
extract children and use before text
92ab9c2
@broccolinisoup
remove logging
7b3d5e6
@siddharthkp
Merge branch 'main' into select-panel-action-list
1cf1e09
@siddharthkp @github-actions
test(vrt): update snapshots
92303d0
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.76 KB (+0.34% 🔺)
packages/react/dist/browser.umd.js 98.14 KB (+0.33% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4927 September 9, 2024 16:30 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4927 September 9, 2024 16:43 Inactive
@siddharthkp siddharthkp mentioned this pull request Sep 12, 2024
Closed
13 tasks
@github-actions github-actions bot temporarily deployed to storybook-preview-4927 September 12, 2024 13:05 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4927 September 12, 2024 13:10 Inactive
@siddharthkp siddharthkp changed the base branch from select-panel-no-matches to main September 16, 2024 14:25
siddharthkp added a commit that referenced this pull request Sep 16, 2024
@siddharthkp
copy changes from #4927
6f35fce
@siddharthkp
Copy link
Member Author

siddharthkp commented Sep 16, 2024

Close in favor of #4968

github-merge-queue bot pushed a commit that referenced this pull request Sep 20, 2024
@siddharthkp
WIP: Select panel custom screen reader announcements (#4968)
da0f48b 
* copy changes from #4927

* fix index to announce

* add liveRegion.clear

* separate type import

* remove hard coded "labels"

* don't assume live region exists

* bump @primer/live-region-element to 0.7.1

* lint!!!
TylerJDev pushed a commit that referenced this pull request Sep 23, 2024
@siddharthkp @TylerJDev
WIP: Select panel custom screen reader announcements (#4968)
6941fd2 
* copy changes from #4927

* fix index to announce

* add liveRegion.clear

* separate type import

* remove hard coded "labels"

* don't assume live region exists

* bump @primer/live-region-element to 0.7.1

* lint!!!
@siddharthkp siddharthkp deleted the select-panel-announcements branch October 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@siddharthkp siddharthkp

Labels

staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siddharthkp @broccolinisoup