Skip to content

SelectPanel2: Move focus to first item if there is no filter input #4320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
siddharthkp merged 3 commits into from
Mar 7, 2024
Merged

SelectPanel2: Move focus to first item if there is no filter input #4320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8c2b77
move focus to list if there is no input
siddharthkp Feb 28, 2024
c741e8f
Create neat-toes-build.md
siddharthkp Feb 28, 2024
66b5d3a
Merge branch 'main' into draft-selectpanel-minimal-initial-focus
siddharthkp Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/neat-toes-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

experimental/SelectPanel: Move focus to first item if there is no filter input
16 changes: 10 additions & 6 deletions packages/react/src/drafts/SelectPanel2/SelectPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,12 +191,16 @@ const Panel: React.FC<SelectPanelProps> = ({
// Autofocus hack: React doesn't support autoFocus for dialog: https://github.com/facebook/react/issues/23301
// tl;dr: react takes over autofocus instead of letting the browser handle it,
// but not for dialogs, so we have to do it
React.useEffect(() => {
if (internalOpen) {
const searchInput = document.querySelector('dialog[open] input') as HTMLInputElement | undefined
searchInput?.focus()
}
}, [internalOpen])
React.useEffect(
function intialFocus() {
if (internalOpen) {
const searchInput = document.querySelector('dialog[open] input') as HTMLInputElement | undefined
if (searchInput) searchInput.focus()
else moveFocusToList()
}
},
[internalOpen],
)

/* Anchored */
const {position} = useAnchoredPosition(
Expand Down