Skip to content

Remove StyledOcticon component #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonrohan merged 10 commits into from
Sep 20, 2023
Merged

Remove StyledOcticon component #3735

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3010f23
Remove StyledOcticon
jonrohan Sep 11, 2023
73e4646
Create kind-readers-grab.md
jonrohan Sep 11, 2023
4446b4c
Update kind-readers-grab.md
jonrohan Sep 11, 2023
799f79c
revert changes
jonrohan Sep 11, 2023
37c9a98
Rebuild package-lock.json
jonrohan Sep 11, 2023
dc47eb5
Merge branch 'next-major' into remove_styledocticon
jonrohan Sep 12, 2023
1b4a04f
Update package-lock.json
jonrohan Sep 12, 2023
7841bc6
Merge branch 'next-major' into remove_styledocticon
jonrohan Sep 20, 2023
961e20b
Update kind-readers-grab.md
jonrohan Sep 20, 2023
7714e23
Update kind-readers-grab.md
jonrohan Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-readers-grab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": major
---

Remove StyledOcticon component. The component was renamed to `Octicon`. Update your imports by swapping `StyledOcticon` with `Octicon`
14 changes: 7 additions & 7 deletions e2e/components/StyledOcticon.test.ts → e2e/components/Octicon.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,25 @@ import {test, expect} from '@playwright/test'
import {visit} from '../test-helpers/storybook'
import {themes} from '../test-helpers/themes'

test.describe('StyledOcticon', () => {
test.describe('Octicon', () => {
test.describe('Default', () => {
for (const theme of themes) {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'components-styledocticon--default',
id: 'components-octicon--default',
globals: {
colorScheme: theme,
},
})

// Default state
expect(await page.screenshot()).toMatchSnapshot(`StyledOcticon.Default.${theme}.png`)
expect(await page.screenshot()).toMatchSnapshot(`Octicon.Default.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-styledocticon--default',
id: 'components-octicon--default',
globals: {
colorScheme: theme,
},
Expand All @@ -36,19 +36,19 @@ test.describe('StyledOcticon', () => {
test.describe(theme, () => {
test('default @vrt', async ({page}) => {
await visit(page, {
id: 'components-styledocticon--playground',
id: 'components-octicon--playground',
globals: {
colorScheme: theme,
},
})

// Default state
expect(await page.screenshot()).toMatchSnapshot(`StyledOcticon.Playground.${theme}.png`)
expect(await page.screenshot()).toMatchSnapshot(`Octicon.Playground.${theme}.png`)
})

test('axe @aat', async ({page}) => {
await visit(page, {
id: 'components-styledocticon--playground',
id: 'components-octicon--playground',
globals: {
colorScheme: theme,
},
Expand Down
Loading