Skip to content

Styled component bug cleanup #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshblack merged 5 commits into from
Jul 27, 2023
Merged

Styled component bug cleanup #3540

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d57dc6e
Styled component bug cleanup
kendallgassner Jul 18, 2023
e3bb20c
changeset
kendallgassner Jul 18, 2023
787489e
Merge branch 'main' into a_couple_of_fixes_found_from_stylelint
kendallgassner Jul 18, 2023
8922236
Merge branch 'main' into a_couple_of_fixes_found_from_stylelint
kendallgassner Jul 19, 2023
0867c26
test(vrt): update snapshots
joshblack Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/hot-planes-check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@primer/react': patch
---

Css styled block fixes

<!-- Changed components: DataTable, Timeline -->
1 change: 1 addition & 0 deletions src/DataTable/Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ const StyledTable = styled.table<React.ComponentPropsWithoutRef<'table'>>`
display: grid;
grid-template-columns: subgrid;
grid-column: -1 /1;
}
}
`

Expand Down
2 changes: 1 addition & 1 deletion src/Timeline/Timeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ const TimelineBody = styled.div<SxProp>`
`

const TimelineBreak = styled.div<SxProp>`
position: relative
position: relative;
z-index: 1;
height: 24px;
margin: 0;
Expand Down
2 changes: 1 addition & 1 deletion src/deprecated/ActionList/Item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ const LeadingVisualContainer = styled(ColoredVisualContainer)`
`

const TrailingContent = styled(ColoredVisualContainer)`
color: ${({variant, disabled}) => getItemVariant(variant, disabled).annotationColor}};
color: ${({variant, disabled}) => getItemVariant(variant, disabled).annotationColor};
margin-left: ${get('space.2')};
margin-right: 0;
width: auto;
Expand Down
2 changes: 1 addition & 1 deletion src/deprecated/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const Button = styled(ButtonBase)<ButtonBaseProps & SxProp>`
color: ${get('colors.btn.text')};
background-color: ${get('colors.btn.bg')};
border: 1px solid ${get('colors.btn.border')};
box-shadow: ${get('shadows.btn.shadow')}, ${get('shadows.btn.insetShadow')}};
box-shadow: ${get('shadows.btn.shadow')}, ${get('shadows.btn.insetShadow')};

&:hover {
background-color: ${get('colors.btn.hoverBg')};
Expand Down