-
Notifications
You must be signed in to change notification settings - Fork 673
Make the showPages prop on our Pagination components responsive
#3390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b0d1f9a
makes the showPages prop on our Pagination components responsive
mperrotti a103211
Update generated/components.json
mperrotti 9655024
updates docs
mperrotti 7361970
adds changeset
mperrotti 7aaa977
Merge branch 'main' into mp/pagination-responsive-showpages
mperrotti 629e435
Merge branch 'mp/pagination-responsive-showpages' of github.com:prime…
mperrotti 802f139
Update generated/components.json
mperrotti 7e52c8f
updates tests
mperrotti 59981ce
Merge branch 'mp/pagination-responsive-showpages' of github.com:prime…
mperrotti 745cd9f
Merge branch 'main' into mp/pagination-responsive-showpages
mperrotti e239bb9
Merge branch 'main' into mp/pagination-responsive-showpages
mperrotti a3fe26d
Merge branch 'main' into mp/pagination-responsive-showpages
mperrotti 8cb045a
updates changeset with changed components
mperrotti d799b8c
updates changeset with changed components again
mperrotti 1fee6f0
refactor to only calculate viewport sizes once
mperrotti 846b48e
Merge branch 'main' of github.com:primer/react into mp/pagination-res…
mperrotti 34bc0c8
Merge branch 'main' into mp/pagination-responsive-showpages
mperrotti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| '@primer/react': minor | ||
| --- | ||
|
|
||
| The showPages prop on both Pagination components can now accept a responsive value. | ||
|
|
||
| <!-- Changed components: DataTable, Pagination --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
hiddenViewportRangesprop something that can be placed onTablePaginationSteps? Would be great to calculate this once and place it on the outermost node and then target it e.g.If not, I think this is something we should calculate once instead of as a function and just pass its value to each
Stepinstead of messing around withuseCallback()and calling it for each step.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh good catch! Ok, I'll refactor 👍