Skip to content

Add back check for GroupContext in ActionList.Selection to fix issues introduced to github/github #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshblack merged 4 commits into from
May 9, 2023
Merged

Add back check for GroupContext in ActionList.Selection to fix issues introduced to github/github #3267

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e63d6e
Add back check for groupContext in ActionList Selection component.
radglob May 9, 2023
4461025
Update src/ActionList/Selection.tsx
radglob May 9, 2023
9a443e8
chore: run format
joshblack May 9, 2023
c206a59
Linting.
radglob May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/ActionList/Selection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,18 @@ import {CheckIcon} from '@primer/octicons-react'
import {ListContext, ActionListProps} from './List'
import {ActionListItemProps} from './shared'
import {LeadingVisualContainer} from './Visuals'
import {ActionListGroupProps, GroupContext} from './Group'

type SelectionProps = Pick<ActionListItemProps, 'selected'>
export const Selection: React.FC<React.PropsWithChildren<SelectionProps>> = ({selected}) => {
const {selectionVariant: groupSelectionVariant} = React.useContext(GroupContext)
const {selectionVariant: listSelectionVariant} = React.useContext(ListContext)

/** selectionVariant in Group can override the selectionVariant in List root */
/** fallback to selectionVariant from container menu if any (ActionMenu, SelectPanel ) */
const selectionVariant: ActionListProps['selectionVariant'] = listSelectionVariant
let selectionVariant: ActionListProps['selectionVariant'] | ActionListGroupProps['selectionVariant']
if (typeof groupSelectionVariant !== 'undefined') selectionVariant = groupSelectionVariant
else selectionVariant = listSelectionVariant

if (!selectionVariant) {
// if selectionVariant is not set on List, but Item is selected
Expand Down