-
Notifications
You must be signed in to change notification settings - Fork 647
Theming for css with primitives #3238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3f12489
minimal setup for css in storybook
siddharthkp 03bb2e4
setup build with rollup
siddharthkp b7b0da2
update snapshot for drafts export
siddharthkp a0643a0
setup jest for css
siddharthkp 0f0c16b
add primer/css as peer and dev dependency
siddharthkp 8d2f89e
use primitives in storybook
siddharthkp be2df33
theming for primitives in BaseStyles
siddharthkp 4712900
Merge branch 'main' into theming-for-css
siddharthkp ee53819
add primitives v8 with fallback to primitives v7
siddharthkp eede7da
missed a spot, prefer v8 over v7
siddharthkp c18b442
update snapshots using basestyles
siddharthkp 7c6d44f
Merge branch 'main' into theming-for-css
siddharthkp 9a07bcd
remove primer/css as peerDep
siddharthkp e6b0848
Merge branch 'theming-for-css' of github.com:primer/react into themin…
siddharthkp a3531aa
change colorMode based on scheme
siddharthkp 4402437
Merge branch 'main' into theming-for-css
siddharthkp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| @import '@primer/css/dist/primitives.css'; | ||
| @import '@primer/css/dist/color-modes.css'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /* size/typography */ | ||
| @import '@primer/primitives/tokens-next-private/css/base/size/size.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/base/typography/typography.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/size/border.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/size/breakpoints.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/size/size-coarse.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/size/size-fine.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/size/size.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/size/viewport.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/typography/typography.css'; | ||
|
|
||
| /* color */ | ||
| @import '@primer/primitives/tokens-next-private/css/functional/themes/light.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/themes/light-tritanopia.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/themes/light-high-contrast.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/themes/light-colorblind.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/themes/dark.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/themes/dark-colorblind.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/themes/dark-dimmed.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/themes/dark-high-contrast.css'; | ||
| @import '@primer/primitives/tokens-next-private/css/functional/themes/dark-tritanopia.css'; |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im a little confused about "day" and "night". Can we standardize on just using light/dark/auto? https://github.com/primer/primitives/blob/main/docs/storybook/.storybook/preview.js#L35
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to 😭 but we've been stuck with this for a while for backward compatibility. Created an issue to deprecate them in next major release