Skip to content

Bug fix: ButtonGroup borders #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
langermank merged 7 commits into from
Apr 20, 2023
Merged

Bug fix: ButtonGroup borders #3198

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bfc9467
fix hover borders
langermank Apr 19, 2023
d1d3841
Create wicked-knives-sparkle.md
langermank Apr 19, 2023
809b01a
snaps
langermank Apr 19, 2023
a78ad2e
why so many snaps?
langermank Apr 19, 2023
124abe7
revert?
langermank Apr 19, 2023
eb50b9a
Merge branch 'main' into wiggly-buttons-strike-back
langermank Apr 19, 2023
3671e7c
test(vrt): update snapshots
langermank Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wicked-knives-sparkle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Bug fix: `ButtonGroup` borders show incorrectly on hover
12 changes: 3 additions & 9 deletions src/ButtonGroup/ButtonGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,23 @@ const ButtonGroup = styled.div`
isolation: isolate;

&& > * {
margin-inline-end: -1px;
position: relative;
border-right-width: 0;
border-radius: 0;

:first-child {
border-top-left-radius: ${get('radii.2')};
border-bottom-left-radius: ${get('radii.2')};
margin-right: 0;
}

:not(:first-child) {
margin-left: 0;
margin-right: 0;
}

:last-child {
border-right-width: 1px;
border-top-right-radius: ${get('radii.2')};
border-bottom-right-radius: ${get('radii.2')};
}

:focus,
:active {
:active,
:hover {
z-index: 1;
}
}
Expand Down