-
Notifications
You must be signed in to change notification settings - Fork 647
PageLayout.Content should not use main landmark by default. #3154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 37 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
67b0aa1
PageLayout.Content should not use main landmark by default.
radglob 6f24481
Create eleven-humans-sneeze.md
radglob 350db20
Revert unrelated snapshots.
radglob e88e8e2
Merge branch 'main' into remove-main-from-pagelayout
radglob e341fd6
Merge branch 'main' into remove-main-from-pagelayout
radglob 4fcb556
Merge branch 'main' into remove-main-from-pagelayout
radglob 410e2f5
Merge branch 'main' into remove-main-from-pagelayout
radglob 49ae6da
Merge branch 'main' into remove-main-from-pagelayout
radglob 5c0fc74
Merge branch 'main' into remove-main-from-pagelayout
radglob bdbfe23
Use explicit main tag in PageLayout test instead of passing as prop.
radglob dc125cb
Merge branch 'main' into remove-main-from-pagelayout
radglob 9bcab34
Merge branch 'main' into remove-main-from-pagelayout
radglob 2375b7a
Merge branch 'main' into remove-main-from-pagelayout
radglob dd4fec7
Merge branch 'main' into remove-main-from-pagelayout
radglob 7ee5c5e
Update generated/components.json
radglob 92cde4c
Merge branch 'main' into remove-main-from-pagelayout
radglob d982926
Merge branch 'main' into remove-main-from-pagelayout
radglob 227ca09
Merge branch 'main' into remove-main-from-pagelayout
radglob d576e8c
Merge branch 'main' into remove-main-from-pagelayout
radglob 87d9eb3
Merge branch 'main' into remove-main-from-pagelayout
radglob bb3f847
Merge branch 'main' into remove-main-from-pagelayout
radglob 8e46eb0
Merge branch 'main' into remove-main-from-pagelayout
radglob 765357a
Merge branch 'main' into remove-main-from-pagelayout
radglob 2b5fd6e
Merge branch 'main' into remove-main-from-pagelayout
radglob 6b99802
Merge branch 'main' into remove-main-from-pagelayout
radglob d7f0d05
PageLayout.Content should not have as prop.
radglob b46b95b
Merge branch 'main' into remove-main-from-pagelayout
radglob 4049117
Merge branch 'main' into remove-main-from-pagelayout
radglob 1b44603
Merge branch 'main' into remove-main-from-pagelayout
radglob fd3f34c
Update generated/components.json
radglob 36dc124
Merge branch 'main' into remove-main-from-pagelayout
radglob 791f595
Merge branch 'main' into remove-main-from-pagelayout
radglob b9cb513
Merge branch 'main' into remove-main-from-pagelayout
radglob 455ecf0
Merge branch 'main' into remove-main-from-pagelayout
radglob 6af4fc0
Merge branch 'main' into remove-main-from-pagelayout
radglob d7e4fbf
Merge branch 'main' into remove-main-from-pagelayout
radglob 0fe571e
Update .changeset/eleven-humans-sneeze.md
radglob 1614457
Don't add role to PageLayout.Content.
radglob 791e307
Merge branch 'main' into remove-main-from-pagelayout
radglob f8c24df
Merge branch 'main' into remove-main-from-pagelayout
radglob 4eb259c
Merge branch 'main' into remove-main-from-pagelayout
radglob File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@primer/react": patch | ||
| --- | ||
|
|
||
| PageLayout.Content no longer renders as `main` by default. Instead, developers may add a `main` landmark within `Pagelayout.Content` themselves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.