Skip to content

Stop rendering activeClassName when there is no to prop is passed for react-router #3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
broccolinisoup merged 2 commits into from
Mar 22, 2023
Merged

Stop rendering activeClassName when there is no to prop is passed for react-router #3061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32f873d
do not render the activeclassname when there is no prop 'to'
broccolinisoup Mar 22, 2023
f6b1096
add changeset
broccolinisoup Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stupid-bats-end.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Stop rendering `activeClassName` when there is no `to` prop is passed for react-router (TabNav, SubNav, BreadCrumb, UnderlineNav v1)
2 changes: 1 addition & 1 deletion src/Breadcrumbs/Breadcrumbs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ type StyledBreadcrumbsItemProps = {
} & SxProp

const BreadcrumbsItem = styled.a.attrs<StyledBreadcrumbsItemProps>(props => ({
activeClassName: typeof props.to === 'string' ? 'selected' : '',
activeClassName: typeof props.to === 'string' ? 'selected' : undefined,
className: classnames(props.selected && SELECTED_CLASS, props.className),
'aria-current': props.selected ? 'page' : null,
}))<StyledBreadcrumbsItemProps>`
Expand Down
2 changes: 1 addition & 1 deletion src/SubNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ type StyledSubNavLinkProps = {
} & SxProp

const SubNavLink = styled.a.attrs<StyledSubNavLinkProps>(props => ({
activeClassName: typeof props.to === 'string' ? 'selected' : '',
activeClassName: typeof props.to === 'string' ? 'selected' : undefined,
className: classnames(ITEM_CLASS, props.selected && SELECTED_CLASS, props.className),
}))<StyledSubNavLinkProps>`
padding-left: ${get('space.3')};
Expand Down
2 changes: 1 addition & 1 deletion src/TabNav/TabNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export type TabNavLinkProps = React.DetailedHTMLProps<React.HTMLAttributes<HTMLA
} & SxProp

const TabNavLink = styled.a.attrs<TabNavLinkProps>(props => ({
activeClassName: typeof props.to === 'string' ? 'selected' : '',
activeClassName: typeof props.to === 'string' ? 'selected' : undefined,
className: classnames(ITEM_CLASS, props.selected && SELECTED_CLASS, props.className),
role: 'tab',
'aria-selected': !!props.selected,
Expand Down
2 changes: 1 addition & 1 deletion src/UnderlineNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ type StyledUnderlineNavLinkProps = {
} & SxProp

const UnderlineNavLink = styled.a.attrs<StyledUnderlineNavLinkProps>(props => ({
activeClassName: typeof props.to === 'string' ? 'selected' : '',
activeClassName: typeof props.to === 'string' ? 'selected' : undefined,
className: classnames(ITEM_CLASS, props.selected && SELECTED_CLASS, props.className),
}))<StyledUnderlineNavLinkProps>`
padding: ${get('space.3')} ${get('space.2')};
Expand Down