Skip to content

Make StateLabel's 'status' prop required #2993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mperrotti merged 8 commits into from
Mar 15, 2023
Merged

Make StateLabel's 'status' prop required #2993

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bde0fb0
makes 'status' prop required
mperrotti Mar 6, 2023
0303df2
adds changeset
mperrotti Mar 6, 2023
ff8406d
Update generated/components.json
mperrotti Mar 6, 2023
21ac56d
Merge branch 'main' of github.com:primer/react into mp/statelabel-sta…
mperrotti Mar 14, 2023
2615906
Merge branch 'mp/statelabel-status-rqd' of github.com:primer/react in…
mperrotti Mar 14, 2023
7340667
rm shouldAcceptCallWithNoProps test
mperrotti Mar 14, 2023
30603ae
Merge branch 'main' into mp/statelabel-status-rqd
mperrotti Mar 15, 2023
b9ffe2f
Merge branch 'main' into mp/statelabel-status-rqd
mperrotti Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/serious-balloons-teach.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Makes StateLabel's 'status' prop required
3 changes: 2 additions & 1 deletion generated/components.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3880,7 +3880,8 @@
},
{
"name": "status",
"type": "'issueOpened' | 'issueClosed' | 'issueClosedNotPlanned' | 'pullOpened' | 'pullClosed' | 'pullMerged' | 'draft' | 'issueDraft'"
"type": "'issueOpened' | 'issueClosed' | 'issueClosedNotPlanned' | 'pullOpened' | 'pullClosed' | 'pullMerged' | 'draft' | 'issueDraft'",
"required": true
},
{
"name": "sx",
Expand Down
3 changes: 2 additions & 1 deletion src/StateLabel/StateLabel.docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
},
{
"name": "status",
"type": "'issueOpened' | 'issueClosed' | 'issueClosedNotPlanned' | 'pullOpened' | 'pullClosed' | 'pullMerged' | 'draft' | 'issueDraft'"
"type": "'issueOpened' | 'issueClosed' | 'issueClosedNotPlanned' | 'pullOpened' | 'pullClosed' | 'pullMerged' | 'draft' | 'issueDraft'",
"required": true
},
{
"name": "sx",
Expand Down
2 changes: 1 addition & 1 deletion src/StateLabel/StateLabel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const sizeVariants = variant({

type StyledStateLabelBaseProps = {
variant?: 'small' | 'normal'
status?: keyof typeof octiconMap
status: keyof typeof octiconMap
} & SxProp

const StateLabelBase = styled.span<StyledStateLabelBaseProps>`
Expand Down