-
Notifications
You must be signed in to change notification settings - Fork 668
feat(project): add warning, invariant utilities and dev-expression plugin #2901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d9cb2f0
chore(project): add warning utility and dev-expression plugin
joshblack 2218347
Merge branch 'main' of github.com:primer/react into chore/add-warning…
joshblack c5289e9
chore: address eslint violations
joshblack 39d859c
Merge branch 'main' of github.com:primer/react into chore/add-warning…
joshblack 3a5c6d2
feat: add invariant and warn helper
joshblack 6a548ed
chore: flip flag for useMedia warning
joshblack b975ab2
chore: add changeset
joshblack 062ea8a
chore: add minified exception case for invariant
joshblack 585992d
chore: update type signature for invariant
joshblack 4dcb508
test: update test for warning helper
joshblack b51b7dd
refactor(hooks): update useControllableState warning usage
joshblack efe6c0c
test(warning): update test titles with flipped condition
joshblack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import {warning} from '../warning' | ||
|
|
||
| test('emits a message to console.warn() when the condition is `false`', () => { | ||
| const spy = jest.spyOn(console, 'warn').mockImplementationOnce(() => {}) | ||
|
|
||
| warning(false, 'test') | ||
|
|
||
| expect(spy).toHaveBeenCalled() | ||
| expect(spy).toHaveBeenCalledWith('Warning: test') | ||
| spy.mockRestore() | ||
| }) | ||
|
|
||
| test('does not emit a message to console.warn() when the condition is `true`', () => { | ||
| const spy = jest.spyOn(console, 'warn').mockImplementationOnce(() => {}) | ||
|
|
||
| warning(true, 'test') | ||
|
|
||
| expect(spy).not.toHaveBeenCalled() | ||
| spy.mockRestore() | ||
| }) | ||
|
|
||
| test('formats arguments into warning string', () => { | ||
| const spy = jest.spyOn(console, 'warn').mockImplementationOnce(() => {}) | ||
|
|
||
| warning(false, 'test %s', 1) | ||
|
|
||
| expect(spy).toHaveBeenCalled() | ||
| expect(spy).toHaveBeenCalledWith('Warning: test 1') | ||
| spy.mockRestore() | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| const emptyFunction = function () {} | ||
|
|
||
| const warning = __DEV__ | ||
| ? function warning(condition: any, format: string, ...args: Array<any>) { | ||
| if (!condition) { | ||
| let index = 0 | ||
| const message = format.replace(/%s/g, () => { | ||
| return args[index++] | ||
| }) | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| console.warn('Warning: ' + message) | ||
| } | ||
| } | ||
| : emptyFunction | ||
|
|
||
| export {warning} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.