Skip to content

Reimplemented tooltips using the Popover API. #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
radglob wants to merge 48 commits into from
Closed

Reimplemented tooltips using the Popover API. #2804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
23b5138
Added story to recreate issue.
radglob Dec 7, 2022
d0e6ebf
Merge branch 'main' of github.com:primer/react into tooltip-in-portal
radglob Dec 12, 2022
c2db73b
Merge branch 'main' of github.com:primer/react into tooltip-in-portal
radglob Dec 13, 2022
bba7717
Merge branch 'main' of github.com:primer/react into tooltip-in-portal
radglob Dec 13, 2022
91df539
Merge branch 'main' of github.com:primer/react into tooltip-in-portal
radglob Dec 19, 2022
ade50dd
Merge branch 'main' of github.com:primer/react into tooltip-popover-api
radglob Jan 5, 2023
46ae8c5
Merge branch 'main' of github.com:primer/react into tooltip-popover-api
radglob Jan 6, 2023
ad08891
Added popover polyfill. Need to work on styling.
radglob Jan 9, 2023
56ae982
Merge branch 'main' of github.com:primer/react into tooltip-popover-api
radglob Jan 10, 2023
ec17288
Update styled-components to add support for shouldForwardProp styled …
radglob Jan 10, 2023
3ee170c
Merge branch 'main' of github.com:primer/react into tooltip-popover-api
radglob Jan 10, 2023
9378324
Updated jest-styled-components, styled-components and snapshots.
radglob Jan 10, 2023
8bcd17d
WIP tooltip fade-in.
radglob Jan 11, 2023
89c0204
Merge branch 'main' of github.com:primer/react into tooltip-popover-api
radglob Jan 17, 2023
5dd1c37
Update popover polyfill to 0.0.6.
radglob Jan 18, 2023
085ce8c
Basic tooltip positioning.
radglob Jan 18, 2023
1594597
Got popover centered correctly. Need to adjust for directions.
radglob Jan 18, 2023
a2d5e48
diagonal directions work.
radglob Jan 19, 2023
21c3f48
different directions working with css properties.
radglob Jan 20, 2023
1c61bdf
Add support for no delay.
radglob Jan 20, 2023
640365e
Show tooltip on focus, hide on blur.
radglob Jan 20, 2023
92040fa
Check if tooltip is visible or not before changing state.
radglob Jan 20, 2023
fb21aee
Simplify positioning code to use shared settings where possible.
radglob Jan 20, 2023
284a6f4
Fixed anchoring.
radglob Jan 23, 2023
500f9a6
Remove old tooltip implementation.
radglob Jan 23, 2023
a59da85
Merge branch 'main' of github.com:primer/react into tooltip-popover-api
radglob Jan 23, 2023
55ee0d4
Merge branch 'main' of github.com:primer/react into tooltip-popover-api
radglob Jan 24, 2023
9166fd4
Got tests working.
radglob Jan 25, 2023
f0f7d5e
Create .changeset/itchy-oranges-live.md
radglob Jan 25, 2023
41ec8a9
Fix forwardRef regression (#2808)
colebemis Jan 24, 2023
23e1bf6
Fix Label `as` prop regression (#2809)
colebemis Jan 24, 2023
44f5478
Fix Truncate regressions (#2810)
colebemis Jan 24, 2023
2fcd695
Update component checklist to reflect the component lifecycle (#2794)
broccolinisoup Jan 25, 2023
e90d119
Fix `as` type errors (#2811)
colebemis Jan 25, 2023
fdd18eb
Version Packages (#2771)
primer-css Jan 25, 2023
d25c56a
Merge branch 'main' of github.com:primer/react into tooltip-popover-api
radglob Jan 25, 2023
96b6e73
Update package-lock.json.
radglob Jan 25, 2023
fe9b45c
Bump @storybook/addon-essentials.
radglob Jan 26, 2023
3af7021
Bump @storybook/react.
radglob Jan 26, 2023
e793cf5
Merge branch 'main' of github.com:primer/react into tooltip-popover-api
radglob Jan 27, 2023
eb1f783
Fix build issues
colebemis Feb 7, 2023
baf5316
Merge branch 'main' of github.com:primer/react into tooltip-popover-api
radglob Feb 7, 2023
1e28494
Fix type-check issues.
radglob Feb 7, 2023
cd0c931
Merge branch 'main' of github.com:primer/react into tooltip-popover-api
radglob Feb 7, 2023
648f8e5
Fix themePreval snapshot.
radglob Feb 7, 2023
d57390a
Conditionally load popover polyfill to fix breaking docs build.
radglob Feb 8, 2023
89002ff
Adding showPopover and hidePopover method stubs to HTMLElement to typ…
radglob Feb 8, 2023
505dbc5
Revert to importing popover polyfill.
radglob Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/itchy-oranges-live.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": minor
---

Reimplemented tooltips using the Popover API. Bumped styled-components to 5.x.
Loading