Skip to content

Add Noto Sans to fontStack #2721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simurai merged 6 commits into from
Dec 26, 2022
Merged

Add Noto Sans to fontStack #2721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c69081
Add `Noto Sans` to fontStack
simurai Dec 22, 2022
820fdda
Create ninety-bobcats-worry.md
simurai Dec 22, 2022
d3a03ab
Update snapshots
colebemis Dec 22, 2022
2f3e686
Merge branch 'main' into noto-sans
simurai Dec 23, 2022
7e624c0
Update more snapshots
simurai Dec 26, 2022
19a27c0
Escape
simurai Dec 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ninety-bobcats-worry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Add `Noto Sans` to fontStack
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/ActionMenu.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`ActionMenu renders consistently 1`] = `
.c0 {
font-family: -apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
font-family: -apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
line-height: 1.5;
color: #24292f;
}
Expand Down
4 changes: 2 additions & 2 deletions src/__tests__/__snapshots__/AnchoredOverlay.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`AnchoredOverlay renders consistently 1`] = `
.c0 {
font-family: -apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
font-family: -apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
line-height: 1.5;
color: #24292f;
}
Expand Down Expand Up @@ -93,7 +93,7 @@ exports[`AnchoredOverlay renders consistently 1`] = `

exports[`AnchoredOverlay should render consistently when open 1`] = `
.c0 {
font-family: -apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
font-family: -apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
line-height: 1.5;
color: #24292f;
}
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/ConfirmationDialog.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`ConfirmationDialog renders consistently 1`] = `
.c0 {
font-family: -apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
font-family: -apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
line-height: 1.5;
color: #24292f;
}
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/SelectPanel.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`SelectPanel renders consistently 1`] = `
.c0 {
font-family: -apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
font-family: -apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
line-height: 1.5;
color: #24292f;
}
Expand Down
4 changes: 2 additions & 2 deletions src/__tests__/__snapshots__/TextInput.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1546,7 +1546,7 @@ exports[`TextInput renders trailingAction icon button 1`] = `
z-index: 1000000;
display: none;
padding: 0.5em 0.75em;
font: normal normal 11px/1.5 -apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
font: normal normal 11px/1.5 -apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
-webkit-font-smoothing: subpixel-antialiased;
color: #ffffff;
text-align: center;
Expand Down Expand Up @@ -2562,7 +2562,7 @@ exports[`TextInput renders trailingAction text button with a tooltip 1`] = `
z-index: 1000000;
display: none;
padding: 0.5em 0.75em;
font: normal normal 11px/1.5 -apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
font: normal normal 11px/1.5 -apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
-webkit-font-smoothing: subpixel-antialiased;
color: #ffffff;
text-align: center;
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/Tooltip.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ exports[`Tooltip renders consistently 1`] = `
z-index: 1000000;
display: none;
padding: 0.5em 0.75em;
font: normal normal 11px/1.5 -apple-system,BlinkMacSystemFont,"Segoe UI",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
font: normal normal 11px/1.5 -apple-system,BlinkMacSystemFont,"Segoe UI","Noto Sans",Helvetica,Arial,sans-serif,"Apple Color Emoji","Segoe UI Emoji";
-webkit-font-smoothing: subpixel-antialiased;
color: #ffffff;
text-align: center;
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/themePreval.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ var themePreval = {
"borderWidths": [0, "1px"],
"breakpoints": ["544px", "768px", "1012px", "1280px"],
"fonts": {
"normal": "-apple-system, BlinkMacSystemFont, \\"Segoe UI\\", Helvetica, Arial, sans-serif, \\"Apple Color Emoji\\", \\"Segoe UI Emoji\\"",
"normal": "-apple-system, BlinkMacSystemFont, \\"Segoe UI\\", \\"Noto Sans\\", Helvetica, Arial, sans-serif, \\"Apple Color Emoji\\", \\"Segoe UI Emoji\\"",
"mono": "SFMono-Regular, Consolas, \\"Liberation Mono\\", Menlo, Courier, monospace"
},
"fontSizes": ["12px", "14px", "16px", "20px", "24px", "32px", "40px", "48px"],
Expand Down
1 change: 1 addition & 0 deletions src/theme-preval.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const fonts = {
'-apple-system',
'BlinkMacSystemFont',
'Segoe UI',
'Noto Sans',
'Helvetica',
'Arial',
'sans-serif',
Expand Down