Skip to content

Add sx prop to Dialog v2 #2712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colebemis merged 4 commits into from
Dec 21, 2022
Merged

Add sx prop to Dialog v2 #2712

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b33e75
fix(Dialog): Add sx prop to Dialog v2
ajhenry Dec 20, 2022
9c1ba17
Merge branch 'main' into ajhenry/fix-dialog-sx
ajhenry Dec 20, 2022
5e45d66
Create quiet-icons-obey.md
colebemis Dec 20, 2022
54bdfd3
Merge branch 'main' into ajhenry/fix-dialog-sx
colebemis Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/quiet-icons-obey.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Add `sx` prop to Dialog v2
4 changes: 3 additions & 1 deletion src/Dialog/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export type DialogButtonProps = ButtonProps & {
/**
* Props to customize the rendering of the Dialog.
*/
export interface DialogProps {
export interface DialogProps extends SxProp {
/**
* Title of the Dialog. Also serves as the aria-label for this Dialog.
*/
Expand Down Expand Up @@ -262,6 +262,7 @@ const _Dialog = React.forwardRef<HTMLDivElement, React.PropsWithChildren<DialogP
width = 'xlarge',
height = 'auto',
footerButtons = [],
sx,
} = props
const dialogLabelId = useId()
const dialogDescriptionId = useId()
Expand Down Expand Up @@ -301,6 +302,7 @@ const _Dialog = React.forwardRef<HTMLDivElement, React.PropsWithChildren<DialogP
role={role}
aria-labelledby={dialogLabelId}
aria-describedby={dialogDescriptionId}
sx={sx}
>
{header}
{body}
Expand Down