Skip to content

FixMarkdownEditor preview overflowing its container #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iansan5653 merged 3 commits into from
Dec 5, 2022
Merged

FixMarkdownEditor preview overflowing its container #2639

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74bc27d
Fix Markdown editor `fieldset` `min-inline-size` styling
iansan5653 Dec 2, 2022
10e75bf
Add changeset
iansan5653 Dec 2, 2022
1ca2467
Merge branch 'main' into fix-markdowneditor-overflow
iansan5653 Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lovely-mangos-destroy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Fix `MarkdownEditor` preview overflowing its container
2 changes: 1 addition & 1 deletion src/drafts/MarkdownEditor/MarkdownEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ const MarkdownEditor = forwardRef<MarkdownEditorHandle, MarkdownEditorProps>(
disabled /* if we set disabled={true}, we can't enable the buttons that should be enabled */
}
aria-describedby={describedBy ? `${descriptionId} ${describedBy}` : descriptionId}
style={{appearance: 'none', border: 'none'}}
style={{appearance: 'none', border: 'none', minInlineSize: 'auto'}}
>
<FormattingTools ref={formattingToolsRef} forInputId={id} />
<div style={{display: 'none'}}>{children}</div>
Expand Down