Re export utils to consumers #4504
Conversation
|
| @@ -1,7 +1,7 @@ | |||
| import React from 'react' | |||
| import {RelativeTimeElement} from '@github/relative-time-element' | |||
| import type {ComponentProps} from '../utils/types' | |||
| import {createComponent} from '../utils/custom-element' | |||
| import {createComponent} from '../utils/customElement' | |||
There was a problem hiding this comment.
renamed this to fit the name of the export
| @@ -0,0 +1,21 @@ | |||
| import isNumeric from './isNumeric' | |||
There was a problem hiding this comment.
Just wanted to check-in, are the exported utilities in this file ones that currently being used externally? If possible, it'd be great to limit what we export publicly to reduce our surface area.
| "import": "./lib-esm/utils/*", | ||
| "require": "./lib/utils/*" | ||
| }, | ||
| "./utils": { |
There was a problem hiding this comment.
Random question, is there an advantage to these being in their own entry point compared to being re-exported from the main entry point?
|
Closing, hopefully #4513 gives us everything we need 🤞 |
Closes #4503
Changelog
New
Export utils under a nicer path
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist