Merge branch 'main' into button-group-shenanigans

.changeset/popular-moose-end.md

@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+Fix `border-color` on ActionList Group header

.changeset/tiny-fireants-deny.md

@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+Remove `min-width` on leading visuals in ActionList

.changeset/tricky-scissors-walk.md

@@ -0,0 +1,5 @@
+---
+"@primer/react": minor
+---
+
+Convert ConfirmationDialog to CSS modules behind feature flag

.eslintrc.js

@@ -200,8 +200,14 @@ module.exports = {
       parserOptions: {
         project: 'tsconfig.json',
       },
-      extends: ['plugin:playwright/jest-playwright'],
-      rules: {},
+      extends: ['plugin:playwright/recommended'],
+      rules: {
+        'playwright/expect-expect': 'off',
+        'playwright/no-conditional-expect': 'off',
+        'playwright/no-conditional-in-test': 'off',
+        'playwright/no-wait-for-selector': 'off',
+        'playwright/valid-title': 'off',
+      },
     },
 
     // rules which apply only to Markdown

.github/workflows/assign_release_conductor.yml

@@ -18,7 +18,6 @@ jobs:
       - uses: actions/setup-node@v4
         with:
           node-version: 22
-      - run: npm i -g npm@^10.5.1
       - run: npm ci
       - uses: ./.github/actions/pagerduty
         id: pagerduty

.github/workflows/check-for-integration-result-comment.yml

@@ -0,0 +1,68 @@
+name: Check for integration result comment
+
+on:
+  issue_comment:
+    types: [created, edited]
+
+jobs:
+  # note: this workflow always passes, it does not fail when integration tests are failing
+  check-for-integration-result-comment:
+    if: github.event.issue.pull_request
+    runs-on: ubuntu-latest
+    steps:
+      - name: Get integration result comment
+        uses: actions/github-script@v7
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const INTEGRATION_LABEL_NAMES = {
+              // synced with https://github.com/primer/react/labels?q=integration-tests
+              skipped: 'integration-tests: skipped manually',
+              recommended: 'integration-tests: recommended',
+              failing: 'integration-tests: failing',
+              passing: 'integration-tests: passing'
+            };
+
+            const issue = {
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo
+            };
+
+            const { data: currentLabels } = await github.rest.issues.listLabelsOnIssue(issue);
+            const existingIntegrationLabels = currentLabels
+              .map(label => label.name)
+              .filter(label => label.startsWith('integration-tests:'));
+
+            if (existingIntegrationLabels.includes(INTEGRATION_LABEL_NAMES.skipped)) return;
+
+            const result = await github.rest.issues.listComments(issue);
+            const integrationComments = result.data.filter(
+              comment =>
+                comment.user.login == 'primer-integration[bot]' &&
+                comment.body.includes('<!-- test-result')
+            );
+            if (integrationComments.length === 0) {
+              console.log('Integration comment with test-result not found');
+              return; // CI should pass if there's nothing to do
+            }
+
+            const latestComment = integrationComments.pop();
+            console.log(latestComment.body);
+
+            // based on comment message in github/github: https://github.com/github/github/blob/fe7fe9072fd913ec04255ce7403ae764e6c33d5f/.github/workflows/github-ci.yml#L664-L692
+            const pass = latestComment.body.includes('🟢');
+            console.log({ pass });
+
+            const newIntegrationLabel = pass ? INTEGRATION_LABEL_NAMES.passing : INTEGRATION_LABEL_NAMES.failing;
+            console.log({existingIntegrationLabels, newIntegrationLabel})
+
+            Object.values(INTEGRATION_LABEL_NAMES).map(async (name) => {
+              if (name === newIntegrationLabel) {
+                if (existingIntegrationLabels.includes(name)); // already added, nothing to do here
+                else await github.rest.issues.addLabels({...issue, labels: [newIntegrationLabel]});
+              } else if (existingIntegrationLabels.includes(name)) {
+                // remove outdated labels
+                await github.rest.issues.removeLabel({ ...issue, name });
+              }
+            });

.github/workflows/ci.yml

@@ -27,7 +27,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Check for unformatted files
@@ -43,7 +42,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Lint JavaScript
@@ -63,7 +61,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build
@@ -81,7 +78,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build project
@@ -99,7 +95,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build
@@ -118,7 +113,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build storybook
@@ -159,7 +153,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: install dependencies
         run: npm ci
       - name: download all reports
@@ -196,7 +189,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build storybook
@@ -237,7 +229,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: install dependencies
         run: npm ci
       - name: download all reports
@@ -270,7 +261,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build storybook
@@ -311,7 +301,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: install dependencies
         run: npm ci
       - name: download all reports
@@ -348,7 +337,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build storybook
@@ -389,7 +377,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: install dependencies
         run: npm ci
       - name: download all reports
@@ -419,7 +406,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build components.json
@@ -435,7 +421,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci
       - name: Build

.github/workflows/codescan.yml

@@ -18,7 +18,6 @@ jobs:
         with:
           node-version: 22
           cache: 'npm'
-      - run: npm i -g npm@^10.5.1
       - name: Install dependencies
         run: npm ci