Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wise-shirts-pull.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/primitives": patch
---

Shadow color adjustments
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -368,4 +368,17 @@
},
},
},
overlay: {
borderColor: {
$value: '{base.color.gray.5}',
$type: 'color',
$extensions: {
'org.primer.figma': {
collection: 'mode',
mode: 'dark',
group: 'component (internal)',
},
},
},
},
}
11 changes: 11 additions & 0 deletions src/tokens/functional/color/dark/patterns-dark.json5
Original file line number Diff line number Diff line change
Expand Up @@ -1903,6 +1903,17 @@
},
},
},
borderColor: {
$value: '{base.color.gray.6}',
$type: 'color',
$extensions: {
'org.primer.figma': {
collection: 'mode',
mode: 'dark',
group: 'component (internal)',
},
},
},
backdrop: {
bgColor: {
$value: '{base.color.gray.8}',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -423,4 +423,17 @@
},
},
},
overlay: {
borderColor: {
$value: '{base.color.gray.8}',
$type: 'color',
$extensions: {
'org.primer.figma': {
collection: 'mode',
mode: 'light',
group: 'component (internal)',
},
},
},
},
}
11 changes: 11 additions & 0 deletions src/tokens/functional/color/light/patterns-light.json5
Original file line number Diff line number Diff line change
Expand Up @@ -1901,6 +1901,17 @@
},
},
},
borderColor: {
$value: '{base.color.transparent}',
$type: 'color',
$extensions: {
'org.primer.figma': {
collection: 'mode',
mode: 'light',
group: 'component (internal)',
},
},
},
backdrop: {
bgColor: {
$value: '{base.color.gray.4}',
Expand Down
8 changes: 4 additions & 4 deletions src/tokens/functional/shadow/dark.json5
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
small: {
$value: [
{
color: '{base.color.gray.8}',
color: '{overlay.borderColor}',
alpha: 1,
offsetX: '0px',
offsetY: '0px',
Expand Down Expand Up @@ -184,7 +184,7 @@
medium: {
$value: [
{
color: '{base.color.gray.8}',
color: '{overlay.borderColor}',
alpha: 1,
offsetX: '0px',
offsetY: '0px',
Expand Down Expand Up @@ -229,7 +229,7 @@
large: {
$value: [
{
color: '{base.color.gray.8}',
color: '{overlay.borderColor}',
alpha: 1,
offsetX: '0px',
offsetY: '0px',
Expand All @@ -250,7 +250,7 @@
xlarge: {
$value: [
{
color: '{base.color.gray.8}',
color: '{overlay.borderColor}',
alpha: 1,
offsetX: '0px',
offsetY: '0px',
Expand Down
32 changes: 32 additions & 0 deletions src/tokens/functional/shadow/light.json5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have an effectively invisible border in light mode? I am fine either way, just asking.

Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,14 @@
floating: {
small: {
$value: [
{
color: '{overlay.borderColor}',
alpha: 1,
offsetX: '0px',
offsetY: '0px',
blur: '0px',
spread: '1px',
},
{
color: '{base.color.gray.7}',
alpha: 0.04,
Expand All @@ -175,6 +183,14 @@
},
medium: {
$value: [
{
color: '{overlay.borderColor}',
alpha: 1,
offsetX: '0px',
offsetY: '0px',
blur: '0px',
spread: '1px',
},
{
color: '{base.color.gray.7}',
alpha: 0.08,
Expand Down Expand Up @@ -212,6 +228,14 @@
},
large: {
$value: [
{
color: '{overlay.borderColor}',
alpha: 1,
offsetX: '0px',
offsetY: '0px',
blur: '0px',
spread: '1px',
},
{
color: '{base.color.gray.7}',
alpha: 0.24,
Expand All @@ -225,6 +249,14 @@
},
xlarge: {
$value: [
{
color: '{overlay.borderColor}',
alpha: 1,
offsetX: '0px',
offsetY: '0px',
blur: '0px',
spread: '1px',
},
{
color: '{base.color.gray.7}',
alpha: 0.32,
Expand Down