Skip to content

some follow-up fixes #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasoppermann merged 3 commits into from
Mar 29, 2023
Merged

some follow-up fixes #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adae9c2
some follow-up fixes
lukasoppermann Mar 29, 2023
f349e30
added changeset
lukasoppermann Mar 29, 2023
5be1175
Merge branch 'main' into a11y-follow-up
lukasoppermann Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/hungry-eels-explain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@primer/primitives': patch
---

- accent.subtle in dark is less opaque to have a 4.5 contrast with new accent color
- danger and close fg slightly changed in light mode to contrast with fg.default (as we have some red links)
- attention.emphasis darker to have 4.5:1 contrast with fg.onEmphasis
2 changes: 1 addition & 1 deletion data/colors/vars/global_dark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default {
fg: '#2f81f7',
emphasis: get('scale.blue.5'),
muted: alpha(get('scale.blue.4'), 0.4),
subtle: alpha(get('scale.blue.4'), 0.15)
subtle: alpha(get('scale.blue.4'), 0.1)
},
success: {
fg: get('scale.green.3'),
Expand Down
6 changes: 3 additions & 3 deletions data/colors/vars/global_light.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default {
},
attention: {
fg: get('scale.yellow.5'),
emphasis: get('scale.yellow.4'),
emphasis: get('scale.yellow.5'),
muted: alpha(get('scale.yellow.3'), 0.4),
subtle: get('scale.yellow.0')
},
Expand All @@ -57,7 +57,7 @@ export default {
subtle: get('scale.orange.0')
},
danger: {
fg: get('scale.red.5'),
fg: '#d1242f',
emphasis: get('scale.red.5'),
muted: alpha(get('scale.red.3'), 0.4),
subtle: get('scale.red.0')
Expand All @@ -69,7 +69,7 @@ export default {
subtle: get('scale.green.0')
},
closed: {
fg: get('scale.red.5'),
fg: get('danger.fg'),
emphasis: get('scale.red.5'),
muted: alpha(get('scale.red.3'), 0.4),
subtle: get('scale.red.0')
Expand Down
2 changes: 1 addition & 1 deletion src/tokens/functional/color/dark/primitives-dark.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
muted: {
$value: '{base.color.blue.4}',
$type: 'color',
alpha: 0.15,
alpha: 0.1,
},
emphasis: {
$value: '{base.color.blue.5}',
Expand Down
8 changes: 6 additions & 2 deletions src/tokens/functional/color/light/primitives-light.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,17 @@
danger: {
$value: '{base.color.red.5}',
$type: 'color',
mix: {
color: '{base.color.red.4}',
weight: 0.05,
},
},
open: {
$value: '{fgColor.success}',
$type: 'color',
},
closed: {
$value: '{base.color.red.5}',
$value: '{fgColor.danger}',
$type: 'color',
},
done: {
Expand Down Expand Up @@ -135,7 +139,7 @@
$type: 'color',
},
emphasis: {
$value: '{base.color.yellow.4}',
$value: '{base.color.yellow.5}',
$type: 'color',
},
},
Expand Down