Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save video-16.svg, video-24.svg #540

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Save video-16.svg, video-24.svg #540

merged 2 commits into from
Feb 2, 2021

Conversation

edokoa
Copy link
Contributor

@edokoa edokoa commented Jan 28, 2021

Adding video icon

@vercel
Copy link

vercel bot commented Jan 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/54v390qa4
✅ Preview: https://octicons-git-video-icon.primer.vercel.app

@vercel vercel bot temporarily deployed to Preview January 28, 2021 10:59 Inactive
Copy link
Contributor

@Juliusschaeper Juliusschaeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" viewBox="0 0 16 16"><path fill-rule="evenodd" d="M1.75 3.5a.25.25 0 00-.25.25v8.5c0 .138.112.25.25.25h12.5a.25.25 0 00.25-.25v-8.5a.25.25 0 00-.25-.25H1.75zM0 3.75C0 2.784.784 2 1.75 2h12.5c.966 0 1.75.784 1.75 1.75v8.5A1.75 1.75 0 0114.25 14H1.75A1.75 1.75 0 010 12.25v-8.5z"/><path d="M6 10.559V5.442a.25.25 0 01.379-.215l4.264 2.559a.25.25 0 010 .428l-4.264 2.559A.25.25 0 016 10.559z"/></svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"><path fill-rule="evenodd" d="M1.75 4.5a.25.25 0 00-.25.25v14.5c0 .138.112.25.25.25h20.5a.25.25 0 00.25-.25V4.75a.25.25 0 00-.25-.25H1.75zM0 4.75C0 3.784.784 3 1.75 3h20.5c.966 0 1.75.784 1.75 1.75v14.5A1.75 1.75 0 0122.25 21H1.75A1.75 1.75 0 010 19.25V4.75z"/><path d="M9 15.584V8.416a.5.5 0 01.77-.42l5.576 3.583a.5.5 0 010 .842L9.77 16.005a.5.5 0 01-.77-.42z"/></svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@ashygee ashygee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@edokoa
Copy link
Contributor Author

edokoa commented Jan 28, 2021

This is the PR for https://github.com/github/design-systems/issues/1155

//cc @ohjoycelau

@ohjoycelau
Copy link

🚀 🚀 🚀

https://github.com/github/design-systems/issues/1155#issuecomment-769267080

Tested in a video block and some other fake instances. Looking good to me 👍 thanks!

Screen Shot 2021-01-28 at 9 56 12 AM

@colebemis colebemis changed the base branch from master to release-11.3.0 February 2, 2021 22:28
@colebemis colebemis merged commit a323e73 into release-11.3.0 Feb 2, 2021
@colebemis colebemis deleted the video-icon branch February 2, 2021 22:29
@colebemis colebemis mentioned this pull request Feb 2, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants