Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 11.2.0 #519

Merged
merged 24 commits into from
Dec 7, 2020
Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
12c5e5a
refine dash and plus to be aligned
ashygee Jun 10, 2020
40778f6
Optimize SVGs
actions-user Jun 10, 2020
4202cab
Merge branch 'master' into fix-alignment
colebemis Jun 12, 2020
089c300
Optimize SVGs
actions-user Jun 12, 2020
e4f2fb0
Small edits
yaili Sep 22, 2020
b747825
Merge branch 'master' into js-edits
ashygee Sep 28, 2020
4ec4065
Merge branch 'master' into js-edits
colebemis Sep 28, 2020
1cf02bd
Bump dot-prop from 4.2.0 to 4.2.1 in /lib/octicons_node
dependabot[bot] Nov 13, 2020
ab15fcb
Bump dot-prop from 4.2.0 to 4.2.1 in /lib/octicons_styled
dependabot[bot] Nov 13, 2020
616fcdb
Bump dot-prop from 4.2.0 to 4.2.1 in /lib/octicons_react
dependabot[bot] Nov 13, 2020
46117a8
Save strikethrough-24.svg, strikethrough-16.svg
edokoa Dec 2, 2020
16847eb
Optimize SVGs
actions-user Dec 2, 2020
c667d69
Save strikethrough-24.svg, strikethrough-16.svg
edokoa Dec 2, 2020
9c6e3d1
Optimize SVGs
actions-user Dec 2, 2020
d2ed431
bumped version to 11.2.0
ashygee Dec 7, 2020
71987db
Merge branch 'master' into fix-alignment
ashygee Dec 7, 2020
5b8103d
update CHANGELOG
ashygee Dec 7, 2020
f55dc98
Merge pull request #518 from primer/Strikethrough-icons
ashygee Dec 7, 2020
5c895f1
Merge pull request #513 from primer/dependabot/npm_and_yarn/lib/octic…
ashygee Dec 7, 2020
c6f1f87
Merge pull request #512 from primer/dependabot/npm_and_yarn/lib/octic…
ashygee Dec 7, 2020
4b25434
Merge pull request #511 from primer/dependabot/npm_and_yarn/lib/octic…
ashygee Dec 7, 2020
ecf9e3c
Merge pull request #499 from primer/js-edits
ashygee Dec 7, 2020
c56ba01
Merge pull request #447 from primer/fix-alignment
ashygee Dec 7, 2020
868e508
Update docs/content/packages/javascript.mdx
ashygee Dec 7, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
# 11.2.0
### 🚀 New Features
- `strikethrough` (https://github.com/primer/octicons/pull/518)

### 🐛 Fixes
- Align `plus` and `dash` icon (https://github.com/primer/octicons/pull/447)
- Small edits in JS documentation (https://github.com/primer/octicons/pull/499)

### 🧽Chores

- Dependency updates

# 11.1.0
### 🚀 New Features
- `container` (https://github.com/primer/octicons/pull/507)
Expand Down
8 changes: 4 additions & 4 deletions docs/content/packages/javascript.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ octicons.x.heights

### `octicons[name].heights[height].width`

Returns the icon's true width, based on the svg view box width. _Note, this doesn't change if you scale it up with size options, it only is the natural width of the icon._
Returns the icon's true width, based on the SVG view box width. _Note, this doesn't change if you scale it up with size options, it only is the natural width of the icon._

### `octicons[name].heights[height].path`

Expand Down Expand Up @@ -134,7 +134,7 @@ octicons.x.toSVG()
// <svg version="1.1" width="12" height="16" viewBox="0 0 12 16" class="octicon octicon-x" aria-hidden="true"><path d="M7.48 8l3.75 3.75-1.48 1.48L6 9.48l-3.75 3.75-1.48-1.48L4.52 8 .77 4.25l1.48-1.48L6 6.52l3.75-3.75 1.48 1.48z"/></svg>
```

The `.toSVG()` method accepts an optional `options` object. This is used to add CSS classnames, a11y options, and sizing.
The `.toSVG()` method accepts an optional `options` object. This is used to add CSS classnames, acessibility options, and sizing.
ashygee marked this conversation as resolved.
Show resolved Hide resolved

#### class

Expand All @@ -154,9 +154,9 @@ octicons.x.toSVG({ "aria-label": "Close the window" })
// <svg version="1.1" width="12" height="16" viewBox="0 0 12 16" class="octicon octicon-x" aria-label="Close the window" role="img"><path d="M7.48 8l3.75 3.75-1.48 1.48L6 9.48l-3.75 3.75-1.48-1.48L4.52 8 .77 4.25l1.48-1.48L6 6.52l3.75-3.75 1.48 1.48z"/></svg>
```

#### width & height
#### width and height

Size the SVG icon larger using `width` & `height` independently or together. `.toSVG()` will automatically choose the best SVG to render based on the width or height passed in.
Size the SVG icon larger using `width` and `height` independently or together. `.toSVG()` will automatically choose the best SVG to render based on the width or height passed in.

```js
octicons.x.toSVG({ "width": 45 })
Expand Down
26 changes: 13 additions & 13 deletions docs/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion icons/dash-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion icons/plus-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/strikethrough-16.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions icons/strikethrough-24.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion lib/octicons_gem/lib/octicons/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Octicons
VERSION = "11.1.0".freeze
VERSION = "11.2.0".freeze
end
2 changes: 1 addition & 1 deletion lib/octicons_helper/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ source "https://rubygems.org"

gemspec

gem "octicons", "11.1.0"
gem "octicons", "11.2.0"
gem "rails"

group :development, :test do
Expand Down
2 changes: 1 addition & 1 deletion lib/octicons_helper/lib/octicons_helper/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module OcticonsHelper
VERSION = "11.1.0".freeze
VERSION = "11.2.0".freeze
end
2 changes: 1 addition & 1 deletion lib/octicons_helper/octicons_helper.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ Gem::Specification.new do |s|

s.require_paths = ["lib"]

s.add_dependency "octicons", "11.1.0"
s.add_dependency "octicons", "11.2.0"
s.add_dependency "rails"
end
2 changes: 1 addition & 1 deletion lib/octicons_jekyll/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ source "https://rubygems.org"

gemspec

gem "octicons", "11.1.0"
gem "octicons", "11.2.0"

group :development, :test do
gem "minitest"
Expand Down
2 changes: 1 addition & 1 deletion lib/octicons_jekyll/jekyll-octicons.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ Gem::Specification.new do |s|
s.require_paths = ["lib"]

s.add_dependency "jekyll", ">= 3.6", "< 5.0"
s.add_dependency "octicons", "11.1.0"
s.add_dependency "octicons", "11.2.0"
end
2 changes: 1 addition & 1 deletion lib/octicons_jekyll/lib/jekyll-octicons/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ module Liquid; class Tag; end; end

module Jekyll
class Octicons < Liquid::Tag
VERSION = "11.1.0".freeze
VERSION = "11.2.0".freeze
end
end
10 changes: 5 additions & 5 deletions lib/octicons_node/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/octicons_node/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@primer/octicons",
"version": "11.1.0",
"version": "11.2.0",
"description": "A scalable set of icons handcrafted with <3 by GitHub.",
"homepage": "https://octicons.github.com",
"author": "GitHub Inc.",
Expand Down
10 changes: 5 additions & 5 deletions lib/octicons_react/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/octicons_react/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@primer/octicons-react",
"version": "11.1.0",
"version": "11.2.0",
"description": "A scalable set of icons handcrafted with <3 by GitHub.",
"homepage": "https://octicons.github.com",
"author": "GitHub, Inc.",
Expand Down
10 changes: 5 additions & 5 deletions lib/octicons_styled/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/octicons_styled/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@primer/styled-octicons",
"version": "11.1.0",
"version": "11.2.0",
"description": "A scalable set of icons handcrafted with <3 by GitHub.",
"homepage": "https://octicons.github.com",
"author": "GitHub, Inc.",
Expand Down
10 changes: 5 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"version": "11.1.0",
"version": "11.2.0",
"scripts": {
"version": "script/version",
"test": "ava -v tests/*.js",
Expand Down