Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save triangle-down-16.svg #459

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Save triangle-down-16.svg #459

merged 2 commits into from
Aug 24, 2020

Conversation

ashygee
Copy link
Contributor

@ashygee ashygee commented Jun 26, 2020

This is a follow up to #457 but uses the correct naming:

This adjusts the triangle-down-16 icon to be one pixel lower.

This image shows a side by side comparison of the updated dropdown caret. left is old with caret centered in container, right is with the caret moved 1px down

Note: image above is from previous PR but the icon has been renamed to triangle-down in the Figma library

@ashygee ashygee requested a review from edokoa June 26, 2020 17:55
@vercel
Copy link

vercel bot commented Jun 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/u1dzc2y3e
✅ Preview: https://octicons-git-fix-triangle-down.primer.vercel.app

@ashygee ashygee mentioned this pull request Aug 24, 2020
5 tasks
@ashygee ashygee changed the base branch from master to release-10.1.0 August 24, 2020 18:47
@ashygee ashygee merged commit 961270a into release-10.1.0 Aug 24, 2020
@ashygee ashygee deleted the fix-triangle-down branch August 24, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants