Add icon-specific className to React default props

[FloEdelmann]

In GitHub, all the icons have a class octicon-${key}, e.g. octicon-arrow-both for the ArrowBothIcon. This PR adds this class to the React components' default props:

  function ArrowBothIcon(props) {
    // …
    return <svg {...getSvgProps({...props, svgDataByHeight})} />
  }

  ArrowBothIcon.defaultProps = {
-   className: 'octicon',
+   className: 'octicon octicon-arrow-both',
    size: 16,
    verticalAlign: 'text-bottom'
  }

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/4pCMWDx4tp5mFvQM2KZ99fymbfmF
✅ Preview: https://octicons-git-fork-floedelmann-class-names-primer.vercel.app

[fregante]

I think this makes sense since by default it also has the octicon class as well

[FloEdelmann]

@colebemis @ashygee Could you please have a quick look at this PR?

[ashygee]

@FloEdelmann Thanks for this and sorry for the delay! I've assigned this to @colebemis and we'll review this week. Apologies for not seeing this sooner.

[FloEdelmann]

@colebemis Sorry to bother you again, but given this is literally only one changed line, I don't understand why you still didn't review. Having that extra class name would be really helpful, e.g. in refined-github/refined-github#3227.

[fregante]

No rush Flo 🤗

[yakov116]

@colebemis friendly bump

[yakov116]

@colebemis @ashygee its almost 7 months since this PR has been opened and 3 releases. Any chance this can be reviewed?

[colebemis]

Looks great! Sorry for the delay.

We'll ship this in our next release.