Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change url for new octicons-v2 #427

Merged
merged 1 commit into from
May 21, 2020
Merged

change url for new octicons-v2 #427

merged 1 commit into from
May 21, 2020

Conversation

ashygee
Copy link
Contributor

@ashygee ashygee commented May 21, 2020

updated link to point to url within primer.style domain.

updated link to point to url within primer.style domain.
@vercel
Copy link

vercel bot commented May 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/octicons/dk1rfcu89
✅ Preview: https://octicons-git-ashygee-patch-1.primer.now.sh

@ashygee ashygee merged commit 00071be into master May 21, 2020
@ashygee ashygee deleted the ashygee-patch-1 branch May 21, 2020 23:08
@colebemis
Copy link
Contributor

primer.style/octicons-v2 points to the icons that in the primer/octicons-v2 which are no longer up-to-date. Here's a diagram that shows the current state of things:

image

Our two options moving forward are to update the alias primer.style/octicons-v2 to point to the most up-to-date v2 icons or revert this PR. I think updating the alias is probably the better option.

@ashygee
Copy link
Contributor Author

ashygee commented May 22, 2020

@colebemis I think that's the better option too. Are you able to do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants