Release 7.3.0 #220
Merged
Release 7.3.0 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing some build error problems
Changing the lerna version preference to locked
shawnbot
approved these changes
May 9, 2018
jonrohan
commented
May 9, 2018
| return c | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
A lot of this removal was taken care of in the svgo file changes above ☝️
emplums
approved these changes
May 9, 2018
| @@ -6,5 +6,5 @@ | |||
| "lib/octicons_helper", | |||
| "lib/jekyll-octicons" | |||
| ], | |||
| "version": "independent" | |||
| "version": "7.3.0" | |||
There was a problem hiding this comment.
Does this get auto updated by lerna or do we have to manually update it?
There was a problem hiding this comment.
running the npm run bump command runs the appropriate lerna command which gives us a nice prompt for deciding.
dmitshur
added a commit
to shurcooL/octicon
that referenced
this pull request
May 12, 2018
Move constants on top of relevant function in generate.go. This should make the code more readable. Follows primer/octicons#220.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a release for Octicons 7.3.0. It adds a new icon, fixes a broken heart, and changes lerna versioning strategy to fixed.
Changelog
Fix for heart icon Fixing jagged heart icon 💔 #211
Closes bugfix #197: broken heart #198
Closes Fix heart icon #197
Adding an archive icon created by @colinkeany
Fixes Octicon request: Archived repo #182
Fixed versioning strategy Changing the lerna version preference to locked #208