Merge pull request #162 from primer/stackFrameHighlight

Use opacity for stackFrameHighlight
primer · Apr 23, 2021 · f242731 · f242731
2 parents feb9a9d + d641912
commit f242731
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/classic/theme.js b/src/classic/theme.js
@@ -184,8 +184,8 @@ function getTheme({ style, name }) {
       "gitDecoration.submoduleResourceForeground": primer.gray[4],
 
       "debugToolBar.background": pick({ light: primer.white, dark: "#2b3036" }),
-      "editor.stackFrameHighlightBackground": pick({ light: primer.yellow[1], dark: "#a707" }),
-      "editor.focusedStackFrameHighlightBackground": pick({ light: primer.yellow[2], dark: "#b808" }),
+      "editor.stackFrameHighlightBackground": pick({ light: "#ffd33d33", dark: "#C6902625" }), // needs opacity (yellow)
+      "editor.focusedStackFrameHighlightBackground": pick({ light: "#28a74525", dark: "#2b6a3033" }), // needs opacity (green)
 
       "peekViewEditor.matchHighlightBackground": pick({ dark: "#ffd33d33" }),
       "peekViewResult.matchHighlightBackground": pick({ dark: "#ffd33d33" }),

diff --git a/src/theme.js b/src/theme.js
@@ -206,8 +206,8 @@ function getTheme({ theme, name }) {
       "gitDecoration.submoduleResourceForeground"  : color.text.secondary,
 
       "debugToolBar.background"                    : color.bg.overlay,
-      "editor.stackFrameHighlightBackground"       : themes({ light: scale.yellow[1], dark: "#a707", dimmed: "#a707" }),
-      "editor.focusedStackFrameHighlightBackground": themes({ light: scale.yellow[2], dark: "#b808", dimmed: "#b808" }),
+      "editor.stackFrameHighlightBackground"       : themes({ light: "#ffd33d33", dark: "#D2992225", dimmed: "#C6902625" }), // needs opacity (yellow)
+      "editor.focusedStackFrameHighlightBackground": themes({ light: "#28a74525", dark: "#3FB95025", dimmed: "#2b6a3033" }), // needs opacity (green)
 
       "peekViewEditor.matchHighlightBackground": themes({ dark: "#ffd33d33", dimmed: "#ffd33d33" }),
       "peekViewResult.matchHighlightBackground": themes({ dark: "#ffd33d33", dimmed: "#ffd33d33" }),