Merge pull request #156 from primer/fold-background

Use opacity for foldBackground
primer · Apr 16, 2021 · 77a4dbf · 77a4dbf
2 parents 996fc4f + 55021a0
commit 77a4dbf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/classic/theme.js b/src/classic/theme.js
@@ -130,7 +130,7 @@ function getTheme({ style, name }) {
       "editor.foreground": editorForeground,
       "editor.background": pick({ light: primer.white, dark: primer.gray[0] }),
       "editorWidget.background": pick({ light: primer.gray[1], dark: "#1f2428" }),
-      "editor.foldBackground": pick({ light: primer.gray[0], dark: "#282e33" }),
+      "editor.foldBackground": pick({ light: "#d1d5da11", dark: "#58606915" }), // needs opacity
       "editor.lineHighlightBackground": pick({ light: primer.gray[1], dark: "#2b3036" }),
       "editorLineNumber.foreground": pick({ light: "#1b1f234d", dark: primer.gray[2] }),
       "editorLineNumber.activeForeground": editorForeground,

diff --git a/src/theme.js b/src/theme.js
@@ -136,7 +136,7 @@ function getTheme({ theme, name }) {
       "editor.foreground"                 : color.text.primary,
       "editor.background"                 : color.bg.canvas,
       "editorWidget.background"           : color.bg.overlay,
-      "editor.foldBackground"             : color.bg.canvasInset,
+      "editor.foldBackground"             : chroma(scale.gray[4]).alpha(0.1).hex(), // needs opacity
       "editor.lineHighlightBackground"    : color.codemirror.activelineBg,
       "editorLineNumber.foreground"       : color.codemirror.linenumberText,
       "editorLineNumber.activeForeground" : color.text.primary,