Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds explicit-heading rule #65

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

52 changes: 52 additions & 0 deletions src/rules/__tests__/implicit-heading.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
const rule = require('../explicit-heading')
const {RuleTester} = require('eslint')

const ruleTester = new RuleTester({
parserOptions: {
ecmaVersion: 'latest',
sourceType: 'module',
ecmaFeatures: {
jsx: true
}
}
})

ruleTester.run('explicit-heading', rule, {
valid: [
`import {Heading} from '@primer/react';
<Heading as="h1">Heading level 1</Heading>
`,
`import {Heading} from '@primer/react';
<Heading as="h2">Heading level 2</Heading>
`,
`import {Heading} from '@primer/react';
<Heading as="H3">Heading level 2</Heading>
`,
],
invalid: [
{
code: `
import {Heading} from '@primer/react';

<Heading>Heading without "as"</Heading>
`,
errors: [
{
messageId: 'nonExplicitHeadingLevel'
}
]
},
{
code: `
import {Heading} from '@primer/react';

<Heading as="span">Heading component used as "span"</Heading>
`,
errors: [
{
messageId: 'invalidAsValue'
}
]
},
]
})
60 changes: 60 additions & 0 deletions src/rules/explicit-heading.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
const {isPrimerComponent} = require('../utils/is-primer-component')
const {getJSXOpeningElementName} = require('../utils/get-jsx-opening-element-name')
const {getJSXOpeningElementAttribute} = require('../utils/get-jsx-opening-element-attribute')

const validHeadings = ['h1', 'h2', 'h3', 'h4', 'h5', 'h6'];

const isHeading = elem => getJSXOpeningElementName(elem) === 'Heading'
const isUsingAs = elem => {
const asUsage = getJSXOpeningElementAttribute(elem, 'as');

if (!asUsage) return;

return asUsage.value;
}

const isValidAs = value => validHeadings.includes(value.toLowerCase());
const isInvalid = elem => {
const elemAs = isUsingAs(elem);

if (!elemAs) return 'nonExplicitHeadingLevel';
if(!isValidAs(elemAs.value)) return 'invalidAsValue';

return false;
}

module.exports = {
meta: {
type: "problem",
schema: [
{
properties: {
skipImportCheck: {
type: 'boolean'
}
}
}
],
messages: {
nonExplicitHeadingLevel: "Heading must have an explicit heading level applied through `as` prop.",
invalidAsValue: "Usage of `as` must only be used for headings (h1-h6)."
}
},
create: function(context) {
return {
// callback functions
JSXOpeningElement(jsxNode) {
if (isPrimerComponent(jsxNode.name, context.getScope(jsxNode)) && isHeading(jsxNode)) {
const error = isInvalid(jsxNode);

if (error) {
context.report({
node: jsxNode,
messageId: error
})
}
}
}
};
}
};
Loading