Skip to content

Update recommended.js #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francinelucca merged 6 commits into from
Apr 24, 2025
Merged

Update recommended.js #331

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
834ed31
Update recommended.js
francinelucca Apr 24, 2025
07b6b34
update rule message
francinelucca Apr 24, 2025
deb2582
Create honest-adults-add.md
francinelucca Apr 24, 2025
76be780
Create eighty-tips-deliver.md
francinelucca Apr 24, 2025
af83016
disable lint rule
francinelucca Apr 24, 2025
fbd09a8
Merge branch 'francinelucca-patch-1' of https://github.com/primer/esl…
francinelucca Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eighty-tips-deliver.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-primer-react": patch
---

Update message for no-deprecated-experimental-components rule
5 changes: 5 additions & 0 deletions .changeset/honest-adults-add.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-plugin-primer-react": patch
---

Removes primer-react/enforce-css-module-identifier-casing, primer-react/enforce-css-module-default-import from recommended set of rules.
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions src/configs/recommended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ module.exports = {
'primer-react/a11y-use-accessible-tooltip': 'error',
'primer-react/no-unnecessary-components': 'error',
'primer-react/prefer-action-list-item-onselect': 'error',
'primer-react/enforce-css-module-identifier-casing': 'error',
'primer-react/enforce-css-module-default-import': ['error', {enforceName: '(^classes$|Classes$)'}],
},
settings: {
github: {
Expand Down
4 changes: 2 additions & 2 deletions src/rules/__tests__/no-deprecated-experimental-components.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ ruleTester.run('no-deprecated-experimental-components', rule, {
{
code: `import {SelectPanel} from '@primer/react/experimental'`,
errors: [
'SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.',
'The experimental SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.',
],
},
// Multiple experimental import
{
code: `import {SelectPanel, DataTable, ActionBar} from '@primer/react/experimental'`,
errors: [
'SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.',
'The experimental SelectPanel is deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.',
],
},
],
Expand Down
2 changes: 1 addition & 1 deletion src/rules/no-deprecated-experimental-components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
}

if (experimental.length > 0) {
const message = `${components.join(', ')} ${
const message = `The experimental ${components.join(', ')} ${

Check failure on line 55 in src/rules/no-deprecated-experimental-components.js

View workflow job for this annotation

GitHub Actions / lint 

English text in string literals is not allowed
components.length > 1 ? 'are' : 'is'
} deprecated. Please import from the stable entrypoint (@primer/react) if available, or check https://primer.style/product/components/ for alternative components.`

Expand Down
Loading