Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Animated Ellipsis #974

Merged
merged 5 commits into from
Nov 7, 2019
Merged

Add Animated Ellipsis #974

merged 5 commits into from
Nov 7, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Nov 5, 2019 •
edited
Loading

This adds the .AnimatedEllipsis component to Primer CSS.

✨ Docs Preview

loading2

Some improvements over the current animated-ellipsis component:

  • Can be used with any font size
  • Uses only a single element/class
  • Reduced CSS
  • Improved performance by avoiding repainting

TODO

  • Add styles from dotcom
  • Add documentation
  • Refactor

TODO on dotcom

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Nov 5, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/argdnd8oc
🌍 Preview: https://primer-css-git-loaders.primer.now.sh

@simurai simurai changed the base branch from master to release-14.0.0 November 5, 2019 01:55
@simurai simurai changed the title Loaders Add animated ellipsis loader Nov 5, 2019
@simurai simurai changed the title Add animated ellipsis loader Add Animated Ellipsis Nov 5, 2019
@simurai simurai marked this pull request as ready for review November 5, 2019 07:58
@shawnbot shawnbot mentioned this pull request Nov 5, 2019
Merged
19 tasks
@simurai simurai requested a review from shawnbot November 6, 2019 06:17
shawnbot
shawnbot approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice. I love how you pulled it off! ❤️

@simurai simurai merged commit 40aa120 into release-14.0.0 Nov 7, 2019
@simurai simurai deleted the loaders branch November 7, 2019 01:51
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 27, 2022
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

Assignees
No one assigned
Labels
minor release Tag: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simurai @shawnbot