Skip to content

Conversation

@gr2m
Copy link
Contributor

@gr2m gr2m commented Jun 2, 2023

We cannot add @changesets/cli as dependency because it conflicts with primer-changesets-cli

This is required for primer/react#3352

…ts/action` action

We cannot add `@changesets/cli` as dependency because it conflicts with `primer-changesets-cli`

This is required for primer/react#3352
@lesliecdubs lesliecdubs requested a review from joshblack June 3, 2023 02:22
@joshblack
Copy link
Member

Sorry for the delay on this @gr2m!

Just wanted to double check since this is a shared action, will this impact any projects that are using different versions of the changeset cli package? (older or newer)

What would the process be if downstream teams would like to update to newer versions of this package?

@gr2m
Copy link
Contributor Author

gr2m commented Jun 7, 2023

Good question. There is a theoretical chance that things might break, but

  1. the @changesets/cli version had no breaking changes for 4 years
  2. Even if a breaking change occurs, I think it's unlikely that the format of the .changesets/*.md files change. That means we don't need to update the workflow file even when repositories start using a new @changesets/cli version
  3. If there is a breaking change to the format of the changesets file, we will have to update the line and also update primer-changesets-cli

@gr2m gr2m merged commit 20d18bb into primer:main Jun 22, 2023
@gr2m gr2m deleted the patch-1 branch June 22, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants